linux-kernel - Re: [PATCH 4/8] perf test coresight: Dismiss clang warning for memcpy thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250926161941.GG7985@e132581.arm.com>
Date: Fri, 26 Sep 2025 17:19:41 +0100
From: Leo Yan <leo.yan@....com>
To: Ian Rogers <irogers@...gle.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Quentin Monnet <qmo@...nel.org>,
	Andrii Nakryiko <andrii@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, James Clark <james.clark@...aro.org>,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	llvm@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH 4/8] perf test coresight: Dismiss clang warning for
 memcpy thread

On Thu, Sep 25, 2025 at 12:38:36PM -0700, Ian Rogers wrote:
> On Thu, Sep 25, 2025 at 3:26 AM Leo Yan <leo.yan@....com> wrote:
> >
> > clang-18.1.3 on Ubuntu 24.04.2 reports warning:
> >
> >   memcpy_thread.c:30:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
> >      30 | }
> >         | ^
> >
> > Dismiss the warning with returning NULL from the thread function.
> >
> > Signed-off-by: Leo Yan <leo.yan@....com>
> 
> lgtm, should this be moved into being a perf test workload as in
> tools/perf/tests/workloads/ ?

Now we have four programs under shell folder:

  $ cd linux/tools/perf/tests/shell
  $ find ./ -name *.c -o -name *.S
  ./coresight/unroll_loop_thread/unroll_loop_thread.c
  ./coresight/asm_pure_loop/asm_pure_loop.S
  ./coresight/thread_loop/thread_loop.c
  ./coresight/memcpy_thread/memcpy_thread.c
 
If really do this, can move all programs into folders?

  tools/perf/tests/workloads/       - Common programs
  tools/perf/tests/workloads/arm64  - Arch specific programs

Anyway, this should be a separate series to avoid complexity for
enabling Clang build.

Thanks,
Leo