| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fWb5R3Gu+01Qr0+fu7n=RL8hs2b-timZKzqnATa+DRMyw@mail.gmail.com>
Date: Fri, 26 Sep 2025 09:21:50 -0700
From: Ian Rogers <irogers@...gle.com>
To: Qiao Zhao <qzhao@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>,
Athira Rajeev <atrajeev@...ux.ibm.com>, Chun-Tse Shao <ctshao@...gle.com>,
James Clark <james.clark@...aro.org>, Howard Chu <howardchu95@...il.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 3/3] perf test: Avoid uncore_imc/clockticks in
uniquification test
On Fri, Sep 26, 2025 at 2:00 AM Qiao Zhao <qzhao@...hat.com> wrote:
>
> Hi Ian,
>
> I tested your patch (latest linux-next code + your patch) on hybrid
> CPU machine {CPU Model name: 12th Gen Intel(R) Core(TM) i7-12800HE}
> and failed,
Hi Qiao,
in your output is:
uncore_imc_free_running_0/uncore_imc_free_running,data_total/
ie the uncore PMU is reported twice. This is fixed in the immediately
prior patch in this series:
https://lore.kernel.org/lkml/20250918222202.1353854-3-irogers@google.com/
Thanks,
Ian
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> # perf test -vv "perf stat events uniquifying"
> 95: perf stat events uniquifying:
> --- start ---
> test child forked, pid 21799
> Uniquification of PMU sysfs events test
> Testing event uncore_imc_free_running/data_read/ is uniquified to
> uncore_imc_free_running_0/data_read/
> Uniquification of PMU sysfs events test [Failed]
> # started on Fri Sep 26 04:49:54 2025
>
>
> Performance counter stats for 'system wide':
>
> CPU0 1.47 MiB
> uncore_imc_free_running_0/uncore_imc_free_running,data_read/
> CPU0 1.47 MiB
> uncore_imc_free_running_1/uncore_imc_free_running,data_read/
>
> 0.000925108 seconds time elapsed
>
> Testing event uncore_imc_free_running/data_total/ is uniquified to
> uncore_imc_free_running_0/data_total/
> Uniquification of PMU sysfs events test [Failed]
> # started on Fri Sep 26 04:49:54 2025
>
>
> Performance counter stats for 'system wide':
>
> CPU0 0.59 MiB
> uncore_imc_free_running_0/uncore_imc_free_running,data_total/
> CPU0 0.58 MiB
> uncore_imc_free_running_1/uncore_imc_free_running,data_total/
>
> 0.000969877 seconds time elapsed
>
> Testing event uncore_imc_free_running/data_write/ is uniquified to
> uncore_imc_free_running_0/data_write/
> Uniquification of PMU sysfs events test [Failed]
> # started on Fri Sep 26 04:49:54 2025
>
>
> Performance counter stats for 'system wide':
>
> CPU0 0.00 MiB
> uncore_imc_free_running_0/uncore_imc_free_running,data_write/
> CPU0 0.00 MiB
> uncore_imc_free_running_1/uncore_imc_free_running,data_write/
>
> 0.001183888 seconds time elapsed
>
> Testing event uncore_imc_free_running/data_read/ is uniquified to
> uncore_imc_free_running_1/data_read/
> Uniquification of PMU sysfs events test [Failed]
> # started on Fri Sep 26 04:49:54 2025
>
>
> Performance counter stats for 'system wide':
>
> CPU0 0.29 MiB
> uncore_imc_free_running_0/uncore_imc_free_running,data_read/
> CPU0 0.29 MiB
> uncore_imc_free_running_1/uncore_imc_free_running,data_read/
>
> 0.000710088 seconds time elapsed
>
> Testing event uncore_imc_free_running/data_total/ is uniquified to
> uncore_imc_free_running_1/data_total/
> Uniquification of PMU sysfs events test [Failed]
> # started on Fri Sep 26 04:49:54 2025
>
>
> Performance counter stats for 'system wide':
>
> CPU0 0.62 MiB
> uncore_imc_free_running_0/uncore_imc_free_running,data_total/
> CPU0 0.67 MiB
> uncore_imc_free_running_1/uncore_imc_free_running,data_total/
>
> 0.000959074 seconds time elapsed
>
> Testing event uncore_imc_free_running/data_write/ is uniquified to
> uncore_imc_free_running_1/data_write/
> Uniquification of PMU sysfs events test [Failed]
> # started on Fri Sep 26 04:49:54 2025
>
>
> Performance counter stats for 'system wide':
>
> CPU0 0.23 MiB
> uncore_imc_free_running_0/uncore_imc_free_running,data_write/
> CPU0 0.23 MiB
> uncore_imc_free_running_1/uncore_imc_free_running,data_write/
>
> 0.000775028 seconds time elapsed
>
> ---- end(-1) ----
> 95: perf stat events uniquifying : FAILED!
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> # ls -la /sys/bus/event_source/devices/uncore_imc_free_running_*/events/
> /sys/bus/event_source/devices/uncore_imc_free_running_0/events/:
> total 0
> drwxr-xr-x. 2 root root 0 Sep 26 04:57 .
> drwxr-xr-x. 5 root root 0 Sep 26 01:49 ..
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_read
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_read.scale
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_read.unit
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_total
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_total.scale
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_total.unit
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_write
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_write.scale
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_write.unit
>
> /sys/bus/event_source/devices/uncore_imc_free_running_1/events/:
> total 0
> drwxr-xr-x. 2 root root 0 Sep 26 04:57 .
> drwxr-xr-x. 5 root root 0 Sep 26 01:49 ..
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_read
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_read.scale
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_read.unit
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_total
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_total.scale
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_total.unit
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_write
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_write.scale
> -r--r--r--. 1 root root 4096 Sep 26 01:49 data_write.unit
>
> - Qiao
>
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>
>
> On Fri, Sep 19, 2025 at 6:22 AM Ian Rogers <irogers@...gle.com> wrote:
> >
> > The detection of uncore_imc may happen for free running PMUs and the
> > clockticks event may be present on uncore_clock. Rewrite the test to
> > detect duplicated/deduplicated events from perf list, not hardcoded to
> > uncore_imc.
> >
> > If perf stat fails then assume it is permissions and skip the test.
> >
> > Fixes: 070b315333ee ("perf test: Restrict uniquifying test to machines with 'uncore_imc'")
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
> > .../tests/shell/stat+event_uniquifying.sh | 109 ++++++++----------
> > 1 file changed, 49 insertions(+), 60 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/stat+event_uniquifying.sh b/tools/perf/tests/shell/stat+event_uniquifying.sh
> > index bf54bd6c3e2e..b5dec6b6da36 100755
> > --- a/tools/perf/tests/shell/stat+event_uniquifying.sh
> > +++ b/tools/perf/tests/shell/stat+event_uniquifying.sh
> > @@ -4,74 +4,63 @@
> >
> > set -e
> >
> > -stat_output=$(mktemp /tmp/__perf_test.stat_output.XXXXX)
> > -perf_tool=perf
> > err=0
> > +stat_output=$(mktemp /tmp/__perf_test.stat_output.XXXXX)
> >
> > -test_event_uniquifying() {
> > - # We use `clockticks` in `uncore_imc` to verify the uniquify behavior.
> > - pmu="uncore_imc"
> > - event="clockticks"
> > -
> > - # If the `-A` option is added, the event should be uniquified.
> > - #
> > - # $perf list -v clockticks
> > - #
> > - # List of pre-defined events (to be used in -e or -M):
> > - #
> > - # uncore_imc_0/clockticks/ [Kernel PMU event]
> > - # uncore_imc_1/clockticks/ [Kernel PMU event]
> > - # uncore_imc_2/clockticks/ [Kernel PMU event]
> > - # uncore_imc_3/clockticks/ [Kernel PMU event]
> > - # uncore_imc_4/clockticks/ [Kernel PMU event]
> > - # uncore_imc_5/clockticks/ [Kernel PMU event]
> > - #
> > - # ...
> > - #
> > - # $perf stat -e clockticks -A -- true
> > - #
> > - # Performance counter stats for 'system wide':
> > - #
> > - # CPU0 3,773,018 uncore_imc_0/clockticks/
> > - # CPU0 3,609,025 uncore_imc_1/clockticks/
> > - # CPU0 0 uncore_imc_2/clockticks/
> > - # CPU0 3,230,009 uncore_imc_3/clockticks/
> > - # CPU0 3,049,897 uncore_imc_4/clockticks/
> > - # CPU0 0 uncore_imc_5/clockticks/
> > - #
> > - # 0.002029828 seconds time elapsed
> > -
> > - echo "stat event uniquifying test"
> > - uniquified_event_array=()
> > +cleanup() {
> > + rm -f "${stat_output}"
> >
> > - # Skip if the machine does not have `uncore_imc` device.
> > - if ! ${perf_tool} list pmu | grep -q ${pmu}; then
> > - echo "Target does not support PMU ${pmu} [Skipped]"
> > - err=2
> > - return
> > - fi
> > + trap - EXIT TERM INT
> > +}
> >
> > - # Check how many uniquified events.
> > - while IFS= read -r line; do
> > - uniquified_event=$(echo "$line" | awk '{print $1}')
> > - uniquified_event_array+=("${uniquified_event}")
> > - done < <(${perf_tool} list -v ${event} | grep ${pmu})
> > +trap_cleanup() {
> > + echo "Unexpected signal in ${FUNCNAME[1]}"
> > + cleanup
> > + exit 1
> > +}
> > +trap trap_cleanup EXIT TERM INT
> >
> > - perf_command="${perf_tool} stat -e $event -A -o ${stat_output} -- true"
> > - $perf_command
> > +test_event_uniquifying() {
> > + echo "Uniquification of PMU sysfs events test"
> >
> > - # Check the output contains all uniquified events.
> > - for uniquified_event in "${uniquified_event_array[@]}"; do
> > - if ! cat "${stat_output}" | grep -q "${uniquified_event}"; then
> > - echo "Event is not uniquified [Failed]"
> > - echo "${perf_command}"
> > - cat "${stat_output}"
> > - err=1
> > - break
> > - fi
> > + # Read events from perf list with and without -v. With -v the duplicate PMUs
> > + # aren't deduplicated. Note, json events are listed by perf list without a
> > + # PMU.
> > + read -ra pmu_events <<< "$(perf list --raw pmu)"
> > + read -ra pmu_v_events <<< "$(perf list -v --raw pmu)"
> > + # For all non-deduplicated events.
> > + for pmu_v_event in "${pmu_v_events[@]}"; do
> > + # If the event matches an event in the deduplicated events then it musn't
> > + # be an event with duplicate PMUs, continue the outer loop.
> > + for pmu_event in "${pmu_events[@]}"; do
> > + if [[ "$pmu_v_event" == "$pmu_event" ]]; then
> > + continue 2
> > + fi
> > + done
> > + # Strip the suffix from the non-deduplicated event's PMU.
> > + event=$(echo "$pmu_v_event" | sed -E 's/_[0-9]+//')
> > + for pmu_event in "${pmu_events[@]}"; do
> > + if [[ "$event" == "$pmu_event" ]]; then
> > + echo "Testing event ${event} is uniquified to ${pmu_v_event}"
> > + if ! perf stat -e "$event" -A -o ${stat_output} -- true; then
> > + echo "Error running perf stat for event '$event' [Skip]"
> > + if [ $err = 0 ]; then
> > + err=2
> > + fi
> > + continue
> > + fi
> > + # Ensure the non-deduplicated event appears in the output.
> > + if ! grep -q "${pmu_v_event}" "${stat_output}"; then
> > + echo "Uniquification of PMU sysfs events test [Failed]"
> > + cat "${stat_output}"
> > + err=1
> > + fi
> > + break
> > + fi
> > + done
> > done
> > }
> >
> > test_event_uniquifying
> > -rm -f "${stat_output}"
> > +cleanup
> > exit $err
> > --
> > 2.51.0.470.ga7dc726c21-goog
> >
> >
>
Powered by blists - more mailing lists