linux-kernel - Re: [PATCH] perf: arm_cspmu: fix error handling in arm_cspmu_impl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <541009d1-b0ab-4dc8-81bb-2dd903cd3cf9@web.de>
Date: Sat, 27 Sep 2025 10:28:33 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, linux-arm-kernel@...ts.infradead.org,
 linux-perf-users@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Besar Wicaksono <bwicaksono@...dia.com>,
 Ilkka Koskinen <ilkka@...amperecomputing.com>,
 James Clark <james.clark@...aro.org>, Mark Rutland <mark.rutland@....com>,
 Robin Murphy <robin.murphy@....com>, Suzuki Poulouse
 <suzuki.poulose@....com>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, Will Deacon <will@...nel.org>
Subject: Re: [PATCH] perf: arm_cspmu: fix error handling in
 arm_cspmu_impl_unregister()

> driver_find_device() calls get_device() to increment the reference
> count once a matching device is found. device_release_driver()
> releases the driver, but it does not decrease the reference count that
> was incremented by driver_find_device(). At the end of the loop, there
> is no put_device() to balance the reference count. To avoid reference
> count leakage, add put_device() to decrease the reference count.

Can a summary phrase like “Prevent reference count leaks in arm_cspmu_impl_unregister()”
be more appropriate?

Regards,
Markus