linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: Rework X1-based Asus Zenbook A14's displays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <oVKFPC4z3p0Jkm9UXaUCszvghc54lbXJhAq5VHGVhw1vVmEvDPhVE3VKKaYnWWeycdYZRzzcffAv8mamuh8lvWOVmVtP3uVVoyI2XUyRTms=@vinarskis.com>
Date: Sat, 27 Sep 2025 11:59:23 +0000
From: Aleksandrs Vinarskis <alex@...arskis.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Jens Glathe <jens.glathe@...schoolsolutions.biz>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: Rework X1-based Asus Zenbook A14's displays






On Saturday, September 27th, 2025 at 00:32, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:

> 
> 
> On Fri, Sep 26, 2025 at 09:08:53AM +0200, Aleksandrs Vinarskis wrote:
> 
> > The laptop comes in two variants:
> > 
> > * UX3407RA, higher end, FHD+ OLED or WOXGA+ OLED panels
> > * UX3407QA, lower end, FHD+ OLED or FHD+ LCD panels
> > 
> > Even though all three panels work with "edp-panel", unfortunately the
> > brightness adjustmenet of LCD panel is PWM based, requiring a dedicated
> > device-tree. Convert "x1p42100-asus-zenbook-a14.dts" into ".dtsi" to
> > allow for this split, introduce new LCD variant. Leave current variant
> > without postfix and with the unchanged model name, as some distros
> > (eg. Ubuntu) rely on this for automatic device-tree detection during
> > kernel installation/upgrade.
> > 
> > As dedicated device-tree is required, update compatibles of OLED
> > variants to correct ones. Keep "edp-panel" as fallback, since it is
> > enough to make the panels work.
> > 
> > While at it moving .dts, .dtsi around, drop 'model' from the top level
> > x1-asus-zenbook-a14.dtsi as well.
> > 
> > Signed-off-by: Aleksandrs Vinarskis alex@...arskis.com
> > Co-developed-by: Jens Glathe jens.glathe@...schoolsolutions.biz
> > Signed-off-by: Jens Glathe jens.glathe@...schoolsolutions.biz
> 
> 
> I'm sorry, but I think the order of tags is incorrect. You are sending
> this patch, so your SoB should be the last one.

Checked the docs, you are right, will re-spin.

Thanks,
Alex

> 
> The patch LGTM.
> 
> > ---
> > arch/arm64/boot/dts/qcom/Makefile | 2 +
> > arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi | 7 +-
> > .../boot/dts/qcom/x1e80100-asus-zenbook-a14.dts | 8 ++
> > .../dts/qcom/x1p42100-asus-zenbook-a14-lcd.dts | 62 +++++++++
> > .../boot/dts/qcom/x1p42100-asus-zenbook-a14.dts | 133 ++------------------
> > .../boot/dts/qcom/x1p42100-asus-zenbook-a14.dtsi | 138 +++++++++++++++++++++
> > 6 files changed, 218 insertions(+), 132 deletions(-)
> 
> 
> --
> With best wishes
> Dmitry