linux-kernel - Re: [PATCH] intel_th: core: fix null pointer dereference in intel_th

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c96a836-122b-4f7d-a979-03a0bb6c3d4f@web.de>
Date: Sat, 27 Sep 2025 16:54:59 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: David Arcari <darcari@...hat.com>, kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jerry Hoemann <jerry.hoemann@....com>
Subject: Re: [PATCH] intel_th: core: fix null pointer dereference in
 intel_th_irq

…
> +++ b/drivers/hwtracing/intel_th/core.c
> @@ -715,7 +715,9 @@ intel_th_subdevice_alloc(struct intel_th *th,
>  int intel_th_output_enable(struct intel_th *th, unsigned int otype)
>  {
>  	struct intel_th_device *thdev;
> -	int src = 0, dst = 0;
> +	int src = 0, dst = 0, ret = 0;
> +
> +	disable_irq(th->irq);
…
> -	return 0;
> +	enable_irq(th->irq);
> +	return ret;
>  }
…

How do you think about to increase the application of scope-based resource management?
https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/interrupt.h#L239-L240

Regards,
Markus