linux-kernel - Re: [PATCH] drm/tegra: dc: fix reference leak in tegra_dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025092700-timing-devourer-238c@gregkh>
Date: Sat, 27 Sep 2025 20:09:05 +0200
From: Greg KH <greg@...ah.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: make24@...as.ac.cn, linux-tegra@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, David Airlie <airlied@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Mikko Perttunen <mperttunen@...dia.com>,
	Simona Vetter <simona@...ll.ch>,
	Thierry Reding <thierry.reding@...il.com>, stable@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] drm/tegra: dc: fix reference leak in tegra_dc_couple()

On Sat, Sep 27, 2025 at 02:43:17PM +0200, Markus Elfring wrote:
> > driver_find_device() calls get_device() to increment the reference
> > count once a matching device is found, but there is no put_device() to
> > balance the reference count. To avoid reference count leakage, add
> > put_device() to decrease the reference count.
> 
> How do you think about to increase the application of scope-based resource management?
> https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/device.h#L1180

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot