linux-kernel - Re: [PATCH 8/8] drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509280303.sWeQi4ks-lkp@intel.com>
Date: Sun, 28 Sep 2025 03:37:50 +0800
From: kernel test robot <lkp@...el.com>
To: David Heidelberg via B4 Relay <devnull+david.ixit.cz@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Jessica Zhang <jessica.zhang@....qualcomm.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Casey Connolly <casey.connolly@...aro.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	phone-devel@...r.kernel.org, David Heidelberg <david@...t.cz>
Subject: Re: [PATCH 8/8] drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW
 panel

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ce7f1a983b074f6cf8609068088ca3182c569ee4]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Heidelberg-via-B4-Relay/dt-bindings-panel-Add-Samsung-S6E3FC2X01-DDIC-with-panel/20250925-171444
base:   ce7f1a983b074f6cf8609068088ca3182c569ee4
patch link:    https://lore.kernel.org/r/20250925-s6e3fc2x01-v1-8-9293016768f7%40ixit.cz
patch subject: [PATCH 8/8] drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW panel
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250928/202509280303.sWeQi4ks-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250928/202509280303.sWeQi4ks-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509280303.sWeQi4ks-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c:210:17: warning: unused variable 'dev' [-Wunused-variable]
     210 |         struct device *dev = &ctx->dsi->dev;
         |                        ^~~
>> drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c:256:29: warning: unused variable 'ctx' [-Wunused-variable]
     256 |         struct samsung_s6e3fc2x01 *ctx = to_samsung_s6e3fc2x01(panel);
         |                                    ^~~
   2 warnings generated.


vim +/dev +210 drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c

   206	
   207	static int s6e3fc2x01_prepare(struct drm_panel *panel)
   208	{
   209		struct samsung_s6e3fc2x01 *ctx = to_samsung_s6e3fc2x01(panel);
 > 210		struct device *dev = &ctx->dsi->dev;
   211		int ret;
   212	
   213		ret = regulator_bulk_enable(ARRAY_SIZE(s6e3fc2x01_supplies), ctx->supplies);
   214		if (ret < 0)
   215			return ret;
   216	
   217		s6e3fc2x01_reset(ctx);
   218	
   219		ret = s6e3fc2x01_on(ctx);
   220		if (ret < 0) {
   221			gpiod_set_value_cansleep(ctx->reset_gpio, 0);
   222			regulator_bulk_disable(ARRAY_SIZE(s6e3fc2x01_supplies), ctx->supplies);
   223			return ret;
   224		}
   225	
   226		return 0;
   227	}
   228	
   229	static int s6e3fc2x01_unprepare(struct drm_panel *panel)
   230	{
   231		struct samsung_s6e3fc2x01 *ctx = to_samsung_s6e3fc2x01(panel);
   232	
   233		gpiod_set_value_cansleep(ctx->reset_gpio, 0);
   234		regulator_bulk_disable(ARRAY_SIZE(s6e3fc2x01_supplies), ctx->supplies);
   235	
   236		return 0;
   237	}
   238	
   239	static const struct drm_display_mode ams641rw_mode = {
   240		.clock = (1080 + 72 + 16 + 36) * (2340 + 32 + 4 + 18) * 60 / 1000,
   241		.hdisplay = 1080,
   242		.hsync_start = 1080 + 72,
   243		.hsync_end = 1080 + 72 + 16,
   244		.htotal = 1080 + 72 + 16 + 36,
   245		.vdisplay = 2340,
   246		.vsync_start = 2340 + 32,
   247		.vsync_end = 2340 + 32 + 4,
   248		.vtotal = 2340 + 32 + 4 + 18,
   249		.width_mm = 68,
   250		.height_mm = 145,
   251	};
   252	
   253	static int s6e3fc2x01_get_modes(struct drm_panel *panel,
   254						struct drm_connector *connector)
   255	{
 > 256		struct samsung_s6e3fc2x01 *ctx = to_samsung_s6e3fc2x01(panel);
   257		struct drm_display_mode *mode;
   258	
   259		mode = drm_mode_duplicate(connector->dev, &ams641rw_mode);
   260		if (!mode)
   261			return -ENOMEM;
   262	
   263		drm_mode_set_name(mode);
   264	
   265		mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
   266		connector->display_info.width_mm = mode->width_mm;
   267		connector->display_info.height_mm = mode->height_mm;
   268		drm_mode_probed_add(connector, mode);
   269	
   270		return 1;
   271	}
   272	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki