linux-kernel - Re: [PATCH] i2c: fix reference leak in MP2 PCI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509281317.3OLDoUnB-lkp@intel.com>
Date: Sun, 28 Sep 2025 13:34:11 +0800
From: kernel test robot <lkp@...el.com>
To: Ma Ke <make24@...as.ac.cn>, syniurge@...il.com,
	shyam-sundar.s-k@....com, andi.shyti@...nel.org, wsa@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, Ma Ke <make24@...as.ac.cn>,
	stable@...r.kernel.org
Subject: Re: [PATCH] i2c: fix reference leak in MP2 PCI device

Hi Ma,

kernel test robot noticed the following build errors:

[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on linus/master v6.17-rc7 next-20250926]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ma-Ke/i2c-fix-reference-leak-in-MP2-PCI-device/20250927-190047
base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link:    https://lore.kernel.org/r/20250927105729.19164-1-make24%40iscas.ac.cn
patch subject: [PATCH] i2c: fix reference leak in MP2 PCI device
config: i386-randconfig-011-20250928 (https://download.01.org/0day-ci/archive/20250928/202509281317.3OLDoUnB-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250928/202509281317.3OLDoUnB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509281317.3OLDoUnB-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-amd-mp2-pci.c:467:2: error: use of undeclared identifier 'mp2_dev'
     467 |         mp2_dev = (struct amd_mp2_dev *)pci_get_drvdata(pci_dev);
         |         ^
   drivers/i2c/busses/i2c-amd-mp2-pci.c:469:9: error: use of undeclared identifier 'mp2_dev'; did you mean 'pci_dev'?
     469 |         return mp2_dev;
         |                ^~~~~~~
         |                pci_dev
   drivers/i2c/busses/i2c-amd-mp2-pci.c:460:18: note: 'pci_dev' declared here
     460 |         struct pci_dev *pci_dev;
         |                         ^
>> drivers/i2c/busses/i2c-amd-mp2-pci.c:469:9: error: incompatible pointer types returning 'struct pci_dev *' from a function with result type 'struct amd_mp2_dev *' [-Werror,-Wincompatible-pointer-types]
     469 |         return mp2_dev;
         |                ^~~~~~~
   3 errors generated.


vim +/mp2_dev +467 drivers/i2c/busses/i2c-amd-mp2-pci.c

   456	
   457	struct amd_mp2_dev *amd_mp2_find_device(void)
   458	{
   459		struct device *dev;
   460		struct pci_dev *pci_dev;
   461	
   462		dev = driver_find_next_device(&amd_mp2_pci_driver.driver, NULL);
   463		if (!dev)
   464			return NULL;
   465	
   466		pci_dev = to_pci_dev(dev);
 > 467		mp2_dev = (struct amd_mp2_dev *)pci_get_drvdata(pci_dev);
   468		put_device(dev);
 > 469		return mp2_dev;
   470	}
   471	EXPORT_SYMBOL_GPL(amd_mp2_find_device);
   472	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki