linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E0197AFC-D605-449B-BAA5-AEA0F6C52413@gmail.com>
Date: Sun, 28 Sep 2025 04:21:51 -0300
From: Eric Gonçalves <ghatto404@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins



On September 28, 2025 3:11:16 AM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:
>On Sun, Sep 28, 2025 at 04:45:33AM +0000, Eric Gonçalves wrote:
>> The S20 series has additional reserved pins for the fingerprint sensor,
>> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>> 
>> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
>> Signed-off-by: Eric Gonçalves <ghatto404@...il.com>
>> ---
>> Changes in v2:
>> - Fixed the formatting of the <40 4> line
>> - Added Fixes tag
>> ---
>>  arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> index 96662bf9e527..a87e3d23e3e2 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> @@ -159,7 +159,8 @@ &pon_resin {
>>  };
>>  
>>  &tlmm {
>> -	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
>> +	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
>> +					       <40 4>, /* Unused */
>
>This is still not aligned to the opening angle bracket. Could you please
>recheck your setup?
Yeah, sorry, I had it set to 4 spaces still - I sent a v3.
>
>>  };
>>  
>>  &usb_1 {
>> -- 
>> 2.51.0
>> 
>