[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250928085010-GYC1344940@gentoo.org>
Date: Sun, 28 Sep 2025 16:50:10 +0800
From: Yixun Lan <dlan@...too.org>
To: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: Troy Mitchell <troy.mitchell@...ux.dev>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
Yangyu Chen <cyy@...self.name>, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] riscv: dts: spacemit: Add MusePi Pro board device
tree
Hi Troy,
On 16:05 Sun 28 Sep , Troy Mitchell wrote:
> On Sun, Sep 28, 2025 at 04:00:03PM +0800, Yixun Lan wrote:
> > Hi Troy,
> >
> > On 12:16 Sun 28 Sep , Troy Mitchell wrote:
> > > From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> > >
> > > Add initial device tree support for the MusePi Pro board [1].
> > > The board is using the SpacemiT K1/M1 SoC.
> > >
> > > The device tree is adapted from the SpacemiT vendor tree [2].
> > >
> > > This minimal device tree enables booting into a serial console with UART
> > > output and a blinking LED.
> > >
> > > Link:
> > > https://developer.spacemit.com/documentation?token=YJtdwnvvViPVcmkoPDpcvwfVnrh&type=pdf [1]
> > > https://gitee.com/bianbu-linux/linux-6.6/blob/k1-bl-v2.2.y/arch/riscv/boot/dts/spacemit/k1-x_MUSE-Pi-Pro.dts [2]
> > >
> > same as patch 1
> > > Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> > > ---
..[snip]
> >
> > while you are here, I'd suggest to push as many features as possible
> > instead of this minimal DT, which say - PMU, emmc, ethernet should be ready..
> > (ethernet is in next, should show up at v6.18-rc1)
> Good idea.
> I think I should split these into multiple commits, right?
> Like, PDMA and EMAC should definitely be two separate commits.
>
IMO, not really necessary, but I wouldn't mind either..
--
Yixun Lan (dlan)
Powered by blists - more mailing lists