linux-kernel - Re: [PATCH v2] iio: accel: bma400: Refactor generic interrupt configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250928101241.27a51491@jic23-huawei>
Date: Sun, 28 Sep 2025 10:12:41 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Akshay Jindal <akshayaj.lkd@...il.com>
Cc: dan@...obertson.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, shuah@...nel.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: accel: bma400: Refactor generic interrupt
 configuration

On Sun, 28 Sep 2025 00:13:46 +0530
Akshay Jindal <akshayaj.lkd@...il.com> wrote:

> On Thu, Sep 25, 2025 at 10:39 PM Akshay Jindal <akshayaj.lkd@...il.com> wrote:
> >
> > Refactor generic interrupt configuration to replace hard-coded
> > register values with logical macros and enums, thereby making the
> > configuration understandable and in-style with common kernel
> > patterns.
> >
> > Introduce a const struct with a helper to map event direction to the
> > corresponding generic interrupt and sanitize the input before use.
> >
> > Rename activity_event_en() to generic_event_en() to better describe
> > its role in activity and inactivity detection.
> >
> > No functional changes done.
> >
> > Signed-off-by: Akshay Jindal <akshayaj.lkd@...il.com>
> > ---

> Hello Reviewers,
> After waiting for a week, I have sent v2.
> Requesting your valuable feedback on this.
Hi Akshay,

Really minor process thing.

Even for a request like this, which should have been under the --- in the original
post of v2, crop the content to what matters.

Also, no need to say this at all really!  You waited a reasonable amount of time
given you had some reviews in during that week, and the rest of the comment
is kind of obvious.

So this reply mostly added noise to a busy review queue!

Jonathan


> 
> Thanks,
> Akshay.