linux-kernel - Re: [PATCH] via_wdt: fix critical boot hang due to unnamed resource allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08e2bfe4-8cee-4d72-96ed-30d1e04e8f63@roeck-us.net>
Date: Sun, 28 Sep 2025 07:20:35 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Li Qiang <liqiang01@...inos.cn>, wim@...ux-watchdog.org
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] via_wdt: fix critical boot hang due to unnamed resource
 allocation

On 9/28/25 01:33, Li Qiang wrote:
> The VIA watchdog driver uses allocate_resource() to reserve a MMIO
> region for the watchdog control register. However, the allocated
> resource was not given a name, which causes the kernel resource tree
> to contain an entry marked as "<BAD>" under /proc/iomem on x86
> platforms.
> 
> During boot, this unnamed resource can lead to a critical hang because
> subsequent resource lookups and conflict checks fail to handle the
> invalid entry properly.

FWIW, I only see the name used in print messages, which should show <NULL>
when called with a NULL pointer. Some more details would have been useful,
especially with the idea in mind that a missing resource name should be
reported but not result in a hang and/or crash.

> 
> Signed-off-by: Li Qiang <liqiang01@...inos.cn>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Guenter

> ---
>   drivers/watchdog/via_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index d647923d68fe..f55576392651 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -165,6 +165,7 @@ static int wdt_probe(struct pci_dev *pdev,
>   		dev_err(&pdev->dev, "cannot enable PCI device\n");
>   		return -ENODEV;
>   	}
> +	wdt_res.name = "via_wdt";
>   
>   	/*
>   	 * Allocate a MMIO region which contains watchdog control register