linux-kernel - Re: [PATCH v3 4/7] riscv: sophgo: dts: add PCIe controllers for SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MAUPR01MB110728EEF983FFA560BFEB0B1FE18A@MAUPR01MB11072.INDPRD01.PROD.OUTLOOK.COM>
Date: Mon, 29 Sep 2025 07:53:38 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Manivannan Sadhasivam <mani@...nel.org>, Chen Wang <unicornxw@...il.com>
Cc: kwilczynski@...nel.org, u.kleine-koenig@...libre.com,
 aou@...s.berkeley.edu, alex@...ti.fr, arnd@...db.de, bwawrzyn@...co.com,
 bhelgaas@...gle.com, conor+dt@...nel.org, 18255117159@....com,
 inochiama@...il.com, kishon@...nel.org, krzk+dt@...nel.org,
 lpieralisi@...nel.org, palmer@...belt.com, paul.walmsley@...ive.com,
 robh@...nel.org, s-vadapalli@...com, tglx@...utronix.de,
 thomas.richard@...tlin.com, sycamoremoon376@...il.com,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-riscv@...ts.infradead.org,
 sophgo@...ts.linux.dev, rabenda.cn@...il.com, chao.wei@...hgo.com,
 xiaoguang.xing@...hgo.com, fengchun.li@...hgo.com, jeffbai@...c.io
Subject: Re: [PATCH v3 4/7] riscv: sophgo: dts: add PCIe controllers for
 SG2042


On 9/20/2025 3:42 PM, Manivannan Sadhasivam wrote:
> On Fri, Sep 12, 2025 at 10:36:50AM +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@...look.com>
>>
>> Add PCIe controller nodes in DTS for Sophgo SG2042.
>> Default they are disabled.
>>
>> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
>> Signed-off-by: Han Gao <rabenda.cn@...il.com>
>> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
>> ---
>>   arch/riscv/boot/dts/sophgo/sg2042.dtsi | 88 ++++++++++++++++++++++++++
>>   1 file changed, 88 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
>> index b3e4d3c18fdc..b521f674283e 100644
>> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
>> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
>> @@ -220,6 +220,94 @@ clkgen: clock-controller@...0012000 {
>>   			#clock-cells = <1>;
>>   		};
>>   
>> +		pcie_rc0: pcie@...0000000 {
>> +			compatible = "sophgo,sg2042-pcie-host";
>> +			device_type = "pci";
>> +			reg = <0x70 0x60000000  0x0 0x00800000>,
>> +			      <0x40 0x00000000  0x0 0x00001000>;
>> +			reg-names = "reg", "cfg";
>> +			linux,pci-domain = <0>;
>> +			#address-cells = <3>;
>> +			#size-cells = <2>;
>> +			ranges = <0x01000000 0x0  0xc0000000  0x40 0xc0000000  0x0 0x00400000>,
> PCI address of the I/O port starts from 0. So this should be:
>
> 				<0x01000000 0x0  0x00000000  0x40 0xc0000000  0x0 0x00400000>,
>
> Same comment for other nodes.
>
> With this fixed,
>
> Acked-by: Manivannan Sadhasivam <mani@...nel.org>
>
> - Mani

Thanks, I will fix this in next version.

[......]