linux-kernel - Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250929172724.75108-1-sj@kernel.org>
Date: Mon, 29 Sep 2025 10:27:24 -0700
From: SeongJae Park <sj@...nel.org>
To: Sidharth Seela <sidharthseela@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
	nphamcs@...il.com,
	hannes@...xchg.org,
	nathan@...nel.org,
	shuah@...nel.org,
	morbo@...gle.com,
	justinstitt@...gle.com,
	nick.desaulniers+lkml@...il.com,
	linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev,
	david.hunter.linux@...il.com
Subject: Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label

On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela <sidharthseela@...il.com> wrote:

> Fix warning caused from declaration under a case label. The proper way
> is to declare variable at the beginning of the function. The warning
> came from running clang using LLVM=1; and is as follows:
> --
> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
>   260 |                 char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
>       |
> 
> Signed-off-by: Sidharth Seela <sidharthseela@...il.com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]