linux-kernel - Re: [PATCH] tracing: Fix lock imbalance in s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250929140230.79c06c22@batman.local.home>
Date: Mon, 29 Sep 2025 14:03:24 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Sasha Levin <sashal@...nel.org>
Cc: mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Fix lock imbalance in s_start() memory
 allocation failure path

On Mon, 29 Sep 2025 07:32:38 -0400
Sasha Levin <sashal@...nel.org> wrote:

> iff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 9f3e9537417d5..e00da4182deb7 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -1629,11 +1629,10 @@ static void *s_start(struct seq_file *m, loff_t *pos)
>  	loff_t l;
>  
>  	iter = kzalloc(sizeof(*iter), GFP_KERNEL);
> +	mutex_lock(&event_mutex);
>  	if (!iter)
>  		return NULL;
>  
> -	mutex_lock(&event_mutex);
> -
>  	iter->type = SET_EVENT_FILE;
>  	iter->file = list_entry(&tr->events, struct trace_event_file, list);
>  

Good catch, thanks!

-- Steve