linux-kernel - Re: [PATCH] nfsd: delete unreachable confusing code in nfs4_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175917024706.10236.7663377717231174356.b4-ty@oracle.com>
Date: Mon, 29 Sep 2025 14:24:25 -0400
From: Chuck Lever <cel@...nel.org>
To: Matvey Kovalev <matvey.kovalev@...ras.ru>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	Jeff Layton <jlayton@...nel.org>,
	NeilBrown <neil@...wn.name>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>,
	Tom Talpey <tom@...pey.com>,
	linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] nfsd: delete unreachable confusing code in nfs4_open_delegation()

From: Chuck Lever <chuck.lever@...cle.com>

On Mon, 29 Sep 2025 20:35:20 +0300, Matvey Kovalev wrote:
> op_delegate_type is assigned OPEN_DELEGATE_NONE just before the if-block
> where condition specifies it not be equal to OPEN_DELEGATE_NONE. Compiler
> treats the block as unreachable and optimizes it out from the resulting
> executable.
> 
> In that aspect commit d08d32e6e5c0 ("nfsd4: return delegation immediately
> if lease fails") notably makes no difference.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] nfsd: delete unreachable confusing code in nfs4_open_delegation()
      commit: c4a007c2d1fd7d96fbc3bd4fb45fbbc748d41789

--
Chuck Lever