linux-kernel - Re: [PATCH] usb: dwc3: Don't call clk_bulk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250929234614.sqcigfpqtrkmbjlw@synopsys.com>
Date: Mon, 29 Sep 2025 23:46:15 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ze Huang <huang.ze@...ux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: Don't call clk_bulk_disable_unprepare() twice

On Mon, Sep 29, 2025, Thinh Nguyen wrote:
> On Mon, Sep 29, 2025, Christophe JAILLET wrote:
> > devm_clk_bulk_get_all_enabled() is used in the probe, so
> > clk_bulk_disable_unprepare() should not be called explicitly in the remove
> > function.
> 
> Why not? The clk_bulk_disable_unprepare() is to disable and unprepare
> the clocks, not freeing the clocks.
> 

gah.. I wrote this too quickly without checking...

It does unwind on remove. This is fine.

Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>

BR,
Thinh