linux-kernel - RE: [PATCH v2 1/2] interconnect: qcom: sdx75: Drop QPIC interconnect and BCM nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <410402ca56434110956c802aa760a893@quicinc.com>
Date: Mon, 29 Sep 2025 05:07:54 +0000
From: "Lakshmi Sowjanya D (QUIC)" <quic_laksd@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        "manivannan.sadhasivam@....qualcomm.com"
	<manivannan.sadhasivam@....qualcomm.com>,
        Georgi Djakov <djakov@...nel.org>,
        Rohit Agarwal <quic_rohiagar@...cinc.com>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        "Raviteja Laggyshetty (QUIC)" <quic_rlaggysh@...cinc.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] interconnect: qcom: sdx75: Drop QPIC interconnect
 and BCM nodes



> -----Original Message-----
> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Sent: Friday, September 26, 2025 7:17 PM
> To: manivannan.sadhasivam@....qualcomm.com; Georgi Djakov
> <djakov@...nel.org>; Rohit Agarwal <quic_rohiagar@...cinc.com>; Konrad
> Dybcio <konradybcio@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof
> Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>
> Cc: linux-arm-msm@...r.kernel.org; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org>; devicetree@...r.kernel.org; Manivannan
> Sadhasivam <mani@...nel.org>; Raviteja Laggyshetty (QUIC)
> <quic_rlaggysh@...cinc.com>; Lakshmi Sowjanya D (QUIC)
> <quic_laksd@...cinc.com>; stable@...r.kernel.org
> Subject: Re: [PATCH v2 1/2] interconnect: qcom: sdx75: Drop QPIC
> interconnect and BCM nodes
> 
> On 9/26/25 8:42 AM, Manivannan Sadhasivam via B4 Relay wrote:
> > From: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
> >
> > As like other SDX SoCs, SDX75 SoC's QPIC BCM resource was modeled as a
> > RPMh clock in clk-rpmh driver. However, for SDX75, this resource was
> > also described as an interconnect and BCM node mistakenly. It is
> > incorrect to describe the same resource in two different providers, as
> > it will lead to votes from clients overriding each other.
> >
> > Hence, drop the QPIC interconnect and BCM nodes and let the clients
> > use clk-rpmh driver to vote for this resource.
> >
> > Without this change, the NAND driver fails to probe on SDX75, as the
> > interconnect sync state disables the QPIC nodes as there were no
> > clients voting for this ICC resource. However, the NAND driver had
> > already voted for this BCM resource through the clk-rpmh driver. Since
> > both votes come from Linux, RPMh was unable to distinguish between
> > these two and ends up disabling the QPIC resource during sync state.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: 3642b4e5cbfe ("interconnect: qcom: Add SDX75 interconnect
> > provider driver")
> > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
> > [mani: dropped the reference to bcm_qp0, reworded description]
> > Signed-off-by: Manivannan Sadhasivam
> > <manivannan.sadhasivam@....qualcomm.com>
> > ---
> 
> Too bad no one noticed for the 2 years the platform has been upstream..
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> Konrad

Tested-by: Lakshmi Sowjanya D <quic_laksd@...cinc.com>  # on SDX75

Regards,
Lakshmi Sowjanya D