linux-kernel - Re: [PATCH 06/15] serial: sc16is7xx: use dev_err_probe() instead of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7fe7f1e-df3f-4823-a19c-b581e8bb0eea@kernel.org>
Date: Mon, 29 Sep 2025 08:10:17 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Hugo Villeneuve <hugo@...ovil.com>, gregkh@...uxfoundation.org,
 fvallee@...rea.fr
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH 06/15] serial: sc16is7xx: use dev_err_probe() instead of
 dev_err()

On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> This simplifies code and standardizes the error output.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 7af09535a1563..4384804a4e228 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1528,10 +1528,9 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
>   
>   	/* Alloc port structure */
>   	s = devm_kzalloc(dev, struct_size(s, p, devtype->nr_uart), GFP_KERNEL);
> -	if (!s) {
> -		dev_err(dev, "Error allocating port structure\n");
> -		return -ENOMEM;
> -	}
> +	if (!s)
> +		return dev_err_probe(dev, -ENOMEM,
> +				     "Error allocating port structure\n");

This does not work as you'd expect:
         case -ENOMEM:
                 /* Don't print anything on -ENOMEM, there's already 
enough output */
                 break;

thanks,
-- 
js
suse labs