[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250929-ppp_light_accel_mag_vol-down-v4-0-6598f22d3451@gmail.com>
Date: Mon, 29 Sep 2025 00:35:11 -0700
From: Rudraksha Gupta via B4 Relay <devnull+guptarud.gmail.com@...nel.org>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
Rudraksha Gupta <guptarud@...il.com>, Ondrej Jirman <megi@....cz>,
Martijn Braam <martijn@...xit.nl>,
Kamil TrzciĆski <ayufan@...fan.eu>,
"Leonardo G. Trombetta" <lgtrombetta@....com>
Subject: [PATCH v4 0/4] Upstreaming Pinephone Pro Patches
Throughout the years, many have contributed to the Pinephone Pro (ppp)
development. Unfortunately, these patches are scattered around various
repositories in different states.
I will be attempting to upstream these patches. I will start off with the
following small series:
- Add light/proximity sensor support
- Link: https://codeberg.org/megi/linux/commit/f171bc7013bc7ad3de9af817bfbcbfa548ebe01c
- Add accelerometer sensor support
- Link: https://codeberg.org/megi/linux/commit/b0bb7633e073a6760fa213b8c4a78ea2e73c7bf1
- Add magnetometer sensor support
- Link: https://codeberg.org/megi/linux/commit/2f7e67f451f16eaf15b81aa1dbdf126d54927d35
- Add mount-matrix for magnetometer
- Link: https://codeberg.org/megi/linux/commit/d7cd2eab931e32fa94408a96d73b4e6c0616107a
- Fix voltage threshold for volume down key
- Link: https://codeberg.org/megi/linux/commit/7c496a5cc27ed4e38b740f36c2d8b2c62f80ae54
Unfortunately, because most of userspace (plasma, phosh, kompass,
hwtest, etc.) use the ppp's downstream kernel as a reference, the
incorrect mount matrix for accelerometer and magnetometer have
propogated to userspace, and therefore we can't use them for testing as
they will give the wrong result. Instead, we have to read the raw values
from the device and compare it to
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/mount-matrix.txt#L80-L90
as that will lead to the correct result
I would request reviewers to look at the mount-matrix tests and help me
see if they make sense. I've read the mount-matrix documentation, but it
isn't really clear to me if the values in the tests are the values I
should be getting
Signed-off-by: Rudraksha Gupta <guptarud@...il.com>
---
Changes in v4:
- remove leda-supply and vdd-supply from dts to suppress warning
- credit Martijn and Kamil for the light sensor and accelerometer patches
- Link: https://fosstodon.org/@martijnbraam/115272859701389599
- Link: https://codeberg.org/megi/linux/commit/fc5660685ebe4ecf60226bfa27a1ce47c1c1d020
- combine the magnetometer related patches
- corrected accelerometer's mount matrix to Documentation/devicetree/bindings/iio/mount-matrix.txt
- filled out commit messages
- rebased onto v6.17
- Link to v3: https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v3-0-7af6651f77e4@gmail.com
Changes in v3:
- change magnetometer mount matrix
- update volume button threshold
- Link to v2: https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v2-0-e6bcc6ca74ae@gmail.com
Changes in v2:
- remove usb-typec node in dts from light/proximity sensor patch
- Link to v1: https://lore.kernel.org/r/20250920-ppp_light_accel_mag_vol-down-v1-0-c8bbcd3e2e94@gmail.com
---
Ondrej Jirman (4):
arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support
arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor support
arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support
arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys
.../boot/dts/rockchip/rk3399-pinephone-pro.dts | 40 ++++++++++++++++++++--
1 file changed, 38 insertions(+), 2 deletions(-)
---
base-commit: e5f0a698b34ed76002dc5cff3804a61c80233a7a
change-id: 20250920-ppp_light_accel_mag_vol-down-817c84fdae8d
Best regards,
--
Rudraksha Gupta <guptarud@...il.com>
Powered by blists - more mailing lists