linux-kernel - Re: [PATCH v2 16/16] spi: cadence: Remove explicit device node availability check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250929105424.00007069@huawei.com>
Date: Mon, 29 Sep 2025 10:54:24 +0100
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
CC: <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-input@...r.kernel.org>, <linux-leds@...r.kernel.org>,
	<linux-media@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-spi@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, "Len
 Brown" <lenb@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danilo Krummrich <dakr@...nel.org>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Javier Carrasco
	<javier.carrasco@...fvision.net>, Dmitry Torokhov
	<dmitry.torokhov@...il.com>, Lee Jones <lee@...nel.org>, Pavel Machek
	<pavel@...nel.org>, Matthias Fend <matthias.fend@...end.at>, Chanwoo Choi
	<cw00.choi@...sung.com>, Krzysztof Kozlowski <krzk@...nel.org>, "Laurent
 Pinchart" <laurent.pinchart@...asonboard.com>, Paul Elder
	<paul.elder@...asonboard.com>, Mauro Carvalho Chehab <mchehab@...nel.org>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Mark Brown
	<broonie@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
	<mingo@...nel.org>
Subject: Re: [PATCH v2 16/16] spi: cadence: Remove explicit device node
 availability check

On Wed, 24 Sep 2025 10:46:02 +0300
Sakari Ailus <sakari.ailus@...ux.intel.com> wrote:

> Don't check the availability of child device nodes explicitly as this is
> now embedded in device_for_each_child_node().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

> ---
>  drivers/spi/spi-cadence-xspi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c
> index 6dcba0e0ddaa..23e426ef9b9c 100644
> --- a/drivers/spi/spi-cadence-xspi.c
> +++ b/drivers/spi/spi-cadence-xspi.c
> @@ -908,9 +908,6 @@ static int cdns_xspi_of_get_plat_data(struct platform_device *pdev)
>  	unsigned int cs;
>  
>  	device_for_each_child_node(&pdev->dev, fwnode_child) {
> -		if (!fwnode_device_is_available(fwnode_child))
> -			continue;
> -
>  		if (fwnode_property_read_u32(fwnode_child, "reg", &cs)) {
>  			dev_err(&pdev->dev, "Couldn't get memory chip select\n");
>  			fwnode_handle_put(fwnode_child);