linux-kernel - Re: Re: [PATCH v7 1/1] [DRIVER] gpu: drm: add support for Yhgc ZX1000 soc chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250929110057.8583-1-chuguangqing@inspur.com>
Date: Mon, 29 Sep 2025 19:00:57 +0800
From: Chu Guangqing <chuguangqing@...pur.com>
To: <tzimmermann@...e.de>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <airlied@...il.com>, <simona@...ll.ch>,
	<dmitry.baryshkov@....qualcomm.com>
CC: <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>, Chu
 Guangqing <chuguangqing@...pur.com>
Subject: Re: Re: [PATCH v7 1/1] [DRIVER] gpu: drm: add support for Yhgc ZX1000 soc chipset

Hi Dmitry,

> On Mon, Sep 29, 2025 at 02:31:03PM +0800, Chu Guangqing wrote:
> > add support for Yhgc BMC soc chipset
> 
> So... Again, what is Yhgc? Please expand your commit message, MAINTAINERS
> and Kconfig entries. (this is a usual thing: if you get a review question, it
> usually means that you need to provide more information _in_ the patch
> rather than just reporting on the mailing list). I'd suggest adding full company
> name and maybe a website as a comment inside the driver code. Otherwise it
> would be very hard to assess in few years whether it's something that is still in
> use, whether it needs improvements, etc.
>
This is a spelling error, it should be YHGCH. which has been corrected and is 
now in uppercase. The chip introduction has been added to the commit message, 
and the company's website has been included in the MAINTAINERS file and the 
source code.

The v8 patch:
 https://lore.kernel.org/all/20250929104831.8548-1-chuguangqing@inspur.com/
 
> >
> > Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>
> > ---
> >  MAINTAINERS                            |   5 +
> >  drivers/gpu/drm/Kconfig                |   2 +
> >  drivers/gpu/drm/Makefile               |   1 +
> >  drivers/gpu/drm/yhgch/Kconfig          |  11 +
> >  drivers/gpu/drm/yhgch/Makefile         |   4 +
> >  drivers/gpu/drm/yhgch/yhgch_drm_de.c   | 398

Best Regards,
Chu Guangqing