linux-kernel - Re: [PATCH v4 3/5] dt-bindings: PCI: mediatek: Add support for Airoha AN7583

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175915047324.3882585.17769722251535304485.robh@kernel.org>
Date: Mon, 29 Sep 2025 07:54:33 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: linux-mediatek@...ts.infradead.org, Conor Dooley <conor+dt@...nel.org>, 
 linux-pci@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 linux-kernel@...r.kernel.org, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
 Jianjun Wang <jianjun.wang@...iatek.com>, 
 Bjorn Helgaas <bhelgaas@...gle.com>, 
 Krzysztof Wilczyński <kwilczynski@...nel.org>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 Ryder Lee <ryder.lee@...iatek.com>, Manivannan Sadhasivam <mani@...nel.org>, 
 Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH v4 3/5] dt-bindings: PCI: mediatek: Add support for
 Airoha AN7583


On Mon, 29 Sep 2025 13:38:02 +0200, Christian Marangi wrote:
> Introduce Airoha AN7583 SoC compatible in mediatek PCIe controller
> binding.
> 
> Similar to GEN3, the Airoha AN7583 GEN2 PCIe controller require the
> PBUS csr property to permit the correct functionality of the PCIe
> controller.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  .../bindings/pci/mediatek-pcie.yaml           | 110 ++++++++++++++++++
>  1 file changed, 110 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek-pcie.example.dtb: pcie@...92000 (airoha,an7583-pcie): Unevaluated properties are not allowed ('resets' was unexpected)
	from schema $id: http://devicetree.org/schemas/pci/mediatek-pcie.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250929113806.2484-4-ansuelsmth@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.