linux-kernel - Re: [PATCH 5.15 2/3] NFSv4: Clear NFS_CAP_OPEN_XOR and NFS_CAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025092903-plentiful-banister-9ad0@gregkh>
Date: Mon, 29 Sep 2025 15:24:09 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Siddh Raman Pant <siddh.raman.pant@...cle.com>
Cc: linux-kernel@...r.kernel.org, stable@...nel.org,
	Trond Myklebust <trond.myklebust@...merspace.com>
Subject: Re: [PATCH 5.15 2/3] NFSv4: Clear NFS_CAP_OPEN_XOR and
 NFS_CAP_DELEGTIME if not supported

On Thu, Sep 25, 2025 at 06:31:45PM +0530, Siddh Raman Pant wrote:
> From: Trond Myklebust <trond.myklebust@...merspace.com>
> 
> _nfs4_server_capabilities() should clear capabilities that are not
> supported by the server.
> 
> Fixes: d2a00cceb93a ("NFSv4: Detect support for OPEN4_SHARE_ACCESS_WANT_OPEN_XOR_DELEGATION")
> Signed-off-by: Trond Myklebust <trond.myklebust@...merspace.com>
> (cherry picked from commit b3ac33436030bce37ecb3dcae581ecfaad28078c)
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@...cle.com>
> ---
>  fs/nfs/nfs4proc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 3d854e2537bc..91b95310e107 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3906,7 +3906,8 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f
>  		memcpy(server->attr_bitmask, res.attr_bitmask, sizeof(server->attr_bitmask));
>  		server->caps &=
>  			~(NFS_CAP_ACLS | NFS_CAP_HARDLINKS | NFS_CAP_SYMLINKS |
> -			  NFS_CAP_SECURITY_LABEL | NFS_CAP_FS_LOCATIONS);
> +			  NFS_CAP_SECURITY_LABEL | NFS_CAP_FS_LOCATIONS |
> +			  NFS_CAP_OPEN_XOR | NFS_CAP_DELEGTIME);
>  		server->fattr_valid = NFS_ATTR_FATTR_V4;
>  		if (res.attr_bitmask[0] & FATTR4_WORD0_ACL &&
>  				res.acl_bitmask & ACL4_SUPPORT_ALLOW_ACL)
> -- 
> 2.51.0
> 

This breaks the build :(