linux-kernel - Re: linux-next: build failure after merge of the vfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e987876-9ca8-4670-904f-044c6aa497ff@sirena.org.uk>
Date: Mon, 29 Sep 2025 14:36:58 +0100
From: Mark Brown <broonie@...nel.org>
To: Al Viro <viro@...iv.linux.org.uk>,
	Simon Schuster <schuster.simon@...mens-energy.com>,
	Christian Brauner <brauner@...nel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the vfs tree

On Mon, Sep 29, 2025 at 12:01:15PM +0100, Mark Brown wrote:
> Hi all,
> 
> After merging the vfs tree, today's linux-next build (x86 allmodconfig)
> failed like this:
> 
> In file included from /tmp/next/build/include/rv/ltl_monitor.h:11,
>                  from /tmp/next/build/kernel/trace/rv/monitors/pagefault/pagefault.c:19:
> /tmp/next/build/include/rv/ltl_monitor.h: In function 'ltl_monitor_init':
> /tmp/next/build/include/rv/ltl_monitor.h:75:51: error: passing argument 1 of 'check_trace_callback_type_task_newtask' from incompatible pointer type [-Wincompatible-pointer-types]
>    75 |         rv_attach_trace_probe(name, task_newtask, handle_task_newtask);
>       |                                                   ^~~~~~~~~~~~~~~~~~~
>       |                                                   |
>       |                                                   void (*)(void *, struct task_struct *, long unsigned int)

> I couldn't figure out exactly which commit was causing this in a timely
> fashion (and suspect it may be an interaction with another tree), I've
> used the VFS tree from 20250926 instead.

Actually the whole dance with fs-next meant merging an old version seems
to break.  The issue is due to edd3cb05c00a ("copy_process: pass
clone_flags as u64 across calltree"), I don't see any obvious
interactions but I do note some stuff got silently dropped from that
branch which perhaps was ending up fixing this up?  

I've added the fixup below, and note that -next has been continuing to
carry a revert of "nios2: implement architecture-specific portion of
sys_clone3".

From f308042de4fe7206fc4b75212e9001f54069a20f Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@...nel.org>
Date: Mon, 29 Sep 2025 14:24:24 +0100
Subject: [PATCH] rv: Fix up for clone3() API change

Signed-off-by: Mark Brown <broonie@...nel.org>
---
 include/rv/ltl_monitor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/rv/ltl_monitor.h b/include/rv/ltl_monitor.h
index 67031a774e3d3..5368cf5fd623e 100644
--- a/include/rv/ltl_monitor.h
+++ b/include/rv/ltl_monitor.h
@@ -56,7 +56,7 @@ static void ltl_task_init(struct task_struct *task, bool task_creation)
 	ltl_atoms_fetch(task, mon);
 }
 
-static void handle_task_newtask(void *data, struct task_struct *task, unsigned long flags)
+static void handle_task_newtask(void *data, struct task_struct *task, u64 flags)
 {
 	ltl_task_init(task, true);
 }
-- 
2.47.2


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)