linux-kernel - Re: [PATCH bpf-next v2 3/3] selftests/bpf/benchs: Add producer and overwrite bench for ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81a34994-1975-45bc-a9b4-e35cc9119d0e@huaweicloud.com>
Date: Mon, 29 Sep 2025 21:41:57 +0800
From: Xu Kuohai <xukuohai@...weicloud.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Yonghong Song <yhs@...com>, Song Liu <song@...nel.org>
Subject: Re: [PATCH bpf-next v2 3/3] selftests/bpf/benchs: Add producer and
 overwrite bench for ring buffer

On 9/20/2025 6:15 AM, Andrii Nakryiko wrote:
> On Fri, Sep 5, 2025 at 8:13 AM Xu Kuohai <xukuohai@...weicloud.com> wrote:
>>

[...]

>>
>> -static struct ringbuf_bench *ringbuf_setup_skeleton(void)
>> +static struct ringbuf_bench *ringbuf_setup_skeleton(int bench_prod)
> 
> int because C doesn't support bool?...
>

No special reason, just wrote it like that. I’ll switch it to bool

> but really, do we need another benchmark just to set overwritable
> mode?... can't you adapt existing benchmarks to optionally set
> overwritable mode?
>

OK, I’ll adapt the existing benchmarks to support it.

> 
> (and please drop sdf@...gle.com from CC for the next revision, that
> email doesn't exist anymore)
>

OK

> [...]
>