linux-kernel - Re: [PATCH] vdpa/mlx5: Fix incorrect error code reporting in query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <sdv7e77s7v2hqjkedvhxy4zbwriqu7z6kstfqfnitst4c7yrdv@xcskbqzsf6dl>
Date: Mon, 29 Sep 2025 14:13:36 +0000
From: Dragos Tatulea <dtatulea@...dia.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, mst@...hat.com, 
	jasowang@...hat.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com, 
	tariqt@...dia.com, moshe@...dia.com, kshk@...ux.ibm.com, 
	virtualization@...ts.linux.dev
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Fix incorrect error code reporting in
 query_virtqueues

On Mon, Sep 29, 2025 at 06:42:53AM -0700, Alok Tiwari wrote:
> When query_virtqueues() fails, the error log prints the variable err
> instead of cmd->err. Since err may still be zero at this point, the
> log message can misleadingly report a success value 0 even though the
> command actually failed.
> 
> Even worse, once err is set to the first failure, subsequent logs
> print that same stale value. This makes the error reporting appear
> one step behind the actual failing queue index, which is confusing
> and misleading.
> 
> Fix the log to report cmd->err, which reflects the real failure code
> returned by the firmware.
>
> Fixes: 1fcdf43ea69e ("vdpa/mlx5: Use async API for vq query command")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
Thanks for catching and fixing this Alok. The patch is straightforward
and it looks good to me:

Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>

Thanks,
Dragos