linux-kernel - Re: [PATCH 1/2] dt-bindings: input: pm8941-pwrkey: Document wakeup-source property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0539620-87f8-4efd-b27e-443100bc92cc@lucaweiss.eu>
Date: Mon, 29 Sep 2025 17:44:55 +0200
From: Luca Weiss <luca@...aweiss.eu>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Courtney Cavin <courtney.cavin@...ymobile.com>,
 Vinod Koul <vkoul@...nel.org>, Bhushan Shah <bshah@....org>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-input@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: pm8941-pwrkey: Document
 wakeup-source property

On 25-09-25 7:45 atm, Dmitry Torokhov wrote:
> On Tue, Sep 09, 2025 at 07:54:33AM -0700, Dmitry Torokhov wrote:
>> On Tue, Sep 09, 2025 at 04:41:26PM +0200, Luca Weiss wrote:
>>> On 2025-09-09 16:33, Krzysztof Kozlowski wrote:
>>>> On 09/09/2025 16:08, Dmitry Torokhov wrote:
>>>>>>>     compatible:
>>>>>>>       enum:
>>>>>>> @@ -36,6 +33,11 @@ properties:
>>>>>>>              pin should be configured for pull up.
>>>>>>>       $ref: /schemas/types.yaml#/definitions/flag
>>>>>>>
>>>>>>> +  wakeup-source:
>>>>>>> +    description: |
>>>>>>> +           Button can wake-up the system. Only applicable
>>>>>>> for 'resin',
>>>>>>> +           'pwrkey' always wakes the system by default.
>>>>>>
>>>>>>
>>>>>> I'll fix existing code, so don't repeat that style.
>>>>>
>>>>> If you ack I can reformat on my side to match the patch you just sent.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>
>>> Thanks for fixing that up Krzysztof! I noticed but didn't want to deviate
>>> from the style just for this description. Of course better to fix the
>>> formatting in the first place.
>>>
>>> @Dmitry: Maybe give this patch some time (1-2 weeks?) to gather more
>>> feedback,
>>> given the reasons outlined in the cover letter. Also on the driver patch.
>>
>> OK, I'll hold on to this for a couple of weeks.
> 
> Nobody voiced any objections so far, so applied both.

Thanks Dmitry!