linux-kernel - Re: [PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNqr8+ehPehq41gw@lizhi-Precision-Tower-5810>
Date: Mon, 29 Sep 2025 11:55:31 -0400
From: Frank Li <Frank.li@....com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-i3c@...ts.infradead.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-iio@...r.kernel.org, Carlos Song <carlos.song@....com>
Subject: Re: [PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support

On Mon, Sep 29, 2025 at 05:38:03PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
...

> > @@ -1858,7 +1913,7 @@ static const struct i3c_master_controller_ops svc_i3c_master_ops = {
> >  	.do_daa = svc_i3c_master_do_daa,
> >  	.supports_ccc_cmd = svc_i3c_master_supports_ccc_cmd,
> >  	.send_ccc_cmd = svc_i3c_master_send_ccc_cmd,
> > -	.priv_xfers = svc_i3c_master_priv_xfers,
> > +	.i3c_xfers = svc_i3c_master_i3c_xfers,
>
> Didn't you change this name in patch 1? If you kept both naming, it's
> fine, otherwise you must do the switch in patch 1 as well to make sure
> you don't break the build in the middle of the series.

We keep both API for while. After first patch apply, I change all drivers
to i3c_xfers, then remove old .priv_xfers.

Frank

>
> >  	.i2c_xfers = svc_i3c_master_i2c_xfers,
> >  	.request_ibi = svc_i3c_master_request_ibi,
> >  	.free_ibi = svc_i3c_master_free_ibi,
> > @@ -1947,6 +2002,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> >
> >  	svc_i3c_master_reset(master);
> >
> > +	master->base.mode_mask = BIT(I3C_SDR) | BIT(I3C_HDR_DDR);
> > +
> >  	/* Register the master */
> >  	ret = i3c_master_register(&master->base, &pdev->dev,
> >  				  &svc_i3c_master_ops, false);
>
> Thanks,
> Miquèl