linux-kernel - Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfd8160f015b405623aa7a4b9e69eda2ad1c5df5.camel@codeconstruct.com.au>
Date: Mon, 29 Sep 2025 12:24:03 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Kevin Tung <kevin.tung.openbmc@...il.com>, Rob Herring
 <robh@...nel.org>,  Krzysztof Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley	 <joel@....id.au>, Geert Uytterhoeven
 <geert+renesas@...der.be>, Magnus Damm	 <magnus.damm@...il.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, Amithash Prasasd <amithash@...a.com>, 
 Kevin Tung <Kevin.Tung@...ntatw.com>, Ken Chen <Ken.Chen@...ntatw.com>, Leo
 Yang <Leo-Yang@...ntatw.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemite5: Add Meta Yosemite5
 BMC

Hi Kevin,

On Wed, 2025-09-24 at 20:28 +0800, Kevin Tung wrote:
> Add device tree for the Meta (Facebook) Yosemite5 compute node,
> based on the AST2600 BMC.
> 
> The Yosemite5 platform provides monitoring of voltages, power,
> temperatures, and other critical parameters across the motherboard,
> CXL board, E1.S expansion board, and NIC components. The BMC also
> logs relevant events and performs appropriate system actions in
> response to abnormal conditions.
> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@...il.com>
> ---
>  .../dts/aspeed/aspeed-bmc-facebook-yosemite5.dts   | 1068 ++++++++++++++++++++
>  1 file changed, 1068 insertions(+)

This misses adding the devicetree to the dtb target in
arch/arm/boot/dts/aspeed/Makefile. Consequently I don't expect this was
tested with `make DTBS_CHECK=y ...`. Fixing the make target and
checking the DTB yields the following among the usual concerns:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dtb: ethernet@...70000 (aspeed,ast2600-mac): Unevaluated properties are not allowed ('ncsi-package' was unexpected)
        from schema $id: http://devicetree.org/schemas/net/faraday,ftgmac100.yaml#

Can you please address that? You may need to update or introduce a
binding document as part of doing so if it's not a matter of removing
the property from the devicetree.

Andrew