linux-kernel - Re: [PATCH v1] scsi: ufs: core: Introduce quirk to check UTP error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b60d18d-d590-4fc1-8aff-e8a0fcebd79b@acm.org>
Date: Mon, 29 Sep 2025 09:49:09 -0700
From: Bart Van Assche <bvanassche@....org>
To: HOYOUNG SEO <hy50.seo@...sung.com>, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, alim.akhtar@...sung.com, avri.altman@....com,
 jejb@...ux.ibm.com, martin.petersen@...cle.com, beanhuo@...ron.com,
 kwangwon.min@...sung.com, kwmad.kim@...sung.com, cpgs@...sung.com,
 h10.kim@...sung.com
Subject: Re: [PATCH v1] scsi: ufs: core: Introduce quirk to check UTP error

On 9/29/25 3:58 AM, HOYOUNG SEO wrote:
> +	/*
> +	 * This quirk indicated that report the error when UTP error occurs.
> +	 * Enable this quirk will the error handler allows the ufs to be reocvery.
> +	 */
> +	UFSHCD_QUIRK_UTP_ERROR				= 1 << 26,

Quirks should only be introduced for behavior that differs between host
controllers. I don't see why the behavior introduced by this patch
should only be enabled for some UFS host controllers and not for all UFS
host controllers. Please remove "UFSHCD_QUIRK_UTP_ERROR" from this patch
such that UTP errors trigger UFS error handling for all UFS host
controllers.

Thanks,

Bart.