linux-kernel - Re: [PATCH] net/can/gs_usb: populate net_device->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250930-adorable-loud-scallop-faed25-mkl@pengutronix.de>
Date: Tue, 30 Sep 2025 17:40:23 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Celeste Liu <uwu@...lacanthus.name>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	Maximilian Schneider <max@...neidersoft.net>, linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] net/can/gs_usb: populate net_device->dev_port

On 30.09.2025 14:53:39, Celeste Liu wrote:
> The gs_usb driver supports USB devices with more than 1 CAN channel. In
> old kernel before 3.15, it uses net_device->dev_id to distinguish
> different channel in userspace, which was done in commit
> acff76fa45b4 ("can: gs_usb: gs_make_candev(): set netdev->dev_id").
> But since 3.15, the correct way is populating net_device->dev_port. And
> according to documentation, if network device support multiple interface,
> lack of net_device->dev_port SHALL be treated as a bug.
> 
> Fixes: acff76fa45b4 ("can: gs_usb: gs_make_candev(): set netdev->dev_id")
> Cc: stable@...r.kernel.org
> Signed-off-by: Celeste Liu <uwu@...lacanthus.name>

Applied to linux-can.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)