linux-kernel - Re: [PATCH v3 13/13] nova-core: gsp: Boot GSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ca375c118ff2207baa09e3a6878de546872e250.camel@nvidia.com>
Date: Tue, 30 Sep 2025 17:28:16 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Alistair Popple <apopple@...dia.com>, Alexandre Courbot
	<acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
CC: "lossin@...nel.org" <lossin@...nel.org>, "ojeda@...nel.org"
	<ojeda@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>,
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, John Hubbard
	<jhubbard@...dia.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Joel Fernandes
	<joelagnelf@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>,
	"lyude@...hat.com" <lyude@...hat.com>
Subject: Re: [PATCH v3 13/13] nova-core: gsp: Boot GSP

On Tue, 2025-09-30 at 23:16 +1000, Alistair Popple wrote:
> +        let (mbox0, mbox1) = gsp_falcon.boot(
> +            bar,
> +            Some(libos_handle as u32),
> +            Some((libos_handle >> 32) as u32),
> +        )?;

The only time .boot() is called with None for mbox1 is with fwsec, and I'm pretty sure it doesn't
matter if we set mbox1 to 0 in that call.  So I suggest that we change boot() to take two u32s
instead of two Option<u32> for the mbox registers.  It's just unnecessary complication.