linux-kernel - Re: [PATCH 14/15] serial: sc16is7xx: reformat comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250930154245.93d0405ac3aaa6baa06dd1d8@hugovil.com>
Date: Tue, 30 Sep 2025 15:42:45 -0400
From: Hugo Villeneuve <hugo@...ovil.com>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: gregkh@...uxfoundation.org, fvallee@...rea.fr,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Hugo Villeneuve
 <hvilleneuve@...onoff.com>
Subject: Re: [PATCH 14/15] serial: sc16is7xx: reformat comments

Hi Jiri,

On Mon, 29 Sep 2025 08:18:01 +0200
Jiri Slaby <jirislaby@...nel.org> wrote:

> On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > 
> > Add missing space at end of comments and reformat to have uniform style.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > ---
> >   drivers/tty/serial/sc16is7xx.c | 14 +++++++++-----
> >   1 file changed, 9 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > index 31d43fc857187..b3fbe9459303a 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -81,11 +81,14 @@
> >   /* IER register bits */
> >   #define SC16IS7XX_IER_RDI_BIT		BIT(0)   /* Enable RX data interrupt */
> >   #define SC16IS7XX_IER_THRI_BIT		BIT(1)   /* Enable TX holding register
> > -						  * interrupt */
> > +						  * interrupt
> > +						  */
> 
> I am not forcing this, but maybe put it on one line, if it fits into 100 
> columns? I believe people are using 100 columns nowadays (me included).

Yes good idea. And since the goal of this commit was to try to
uniformize all comments accross the driver, I will probably reformat
most of them to improve readability and follow same convention.

Hugo.

-- 
Hugo Villeneuve