linux-kernel - Re: [PATCH v1 1/2] perf test: Add an 'import perf' test shell script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250930231100.197258-1-collin.funk1@gmail.com>
Date: Tue, 30 Sep 2025 16:10:57 -0700
From: Collin Funk <collin.funk1@...il.com>
To: irogers@...gle.com
Cc: acme@...nel.org,
	adrian.hunter@...el.com,
	alexander.shishkin@...ux.intel.com,
	collin.funk1@...il.com,
	james.clark@...aro.org,
	jolsa@...nel.org,
	kan.liang@...ux.intel.com,
	linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	mark.rutland@....com,
	mingo@...hat.com,
	namhyung@...nel.org,
	peterz@...radead.org,
	ravi.bangoria@....com
Subject: Re: [PATCH v1 1/2] perf test: Add an 'import perf' test shell script

Ian Rogers <irogers@...gle.com> wrote:

> The 'import perf' test needs to set up a path to the python module as
> well as to know the python command to invoke. These are hard coded at
> build time to be build a directory and the python used in the build,
> which is less than desirable. Avoid the hard coded values by reusing
> the existing shell script python setup and determine a potential built
> python module via the path of the perf executable.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/shell/python-use.sh | 36 ++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100755 tools/perf/tests/shell/python-use.sh

Aside from avoiding hard coded build directories, this also looks much cleaner to me.

Reviewed-by Collin Funk <collin.funk1@...il.com>

Collin