linux-kernel - Re: [PATCH V2 3/3] net: ethernet: ti: Remove IS_ERR_OR_NULL checks for knav_dma_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cae855b-e842-47a1-9aaf-b2a297ec32d6@intel.com>
Date: Tue, 30 Sep 2025 16:59:06 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Nishanth Menon <nm@...com>, Uwe Kleine-König
	<u.kleine-koenig@...libre.com>, Paolo Abeni <pabeni@...hat.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S.
 Miller" <davem@...emloft.net>, Andrew Lunn <andrew+netdev@...n.ch>
CC: Santosh Shilimkar <ssantosh@...nel.org>, Simon Horman <horms@...nel.org>,
	Siddharth Vadapalli <s-vadapalli@...com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH V2 3/3] net: ethernet: ti: Remove IS_ERR_OR_NULL checks
 for knav_dma_open_channel



On 9/30/2025 5:16 AM, Nishanth Menon wrote:
> knav_dma_open_channel now only returns NULL on failure instead of error
> pointers. Replace IS_ERR_OR_NULL checks with simple NULL checks.
> 
> Suggested-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> Changes in V2:
> * renewed version
> * Dropped the fixes since code refactoring was involved.
> 

Whats the justification for splitting this apart from patch 1 of 3?

It seems like we ought to just do all this in a single patch. I don't
see the value in splitting this apart into 3 patches, unless someone
else on the list thinks it is valuable.

> V1: https://lore.kernel.org/all/20250926150853.2907028-1-nm@ti.com/
> 
>  drivers/net/ethernet/ti/netcp_core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
> index 2f9d26c791e3..5ee13db568f0 100644
> --- a/drivers/net/ethernet/ti/netcp_core.c
> +++ b/drivers/net/ethernet/ti/netcp_core.c
> @@ -1338,7 +1338,7 @@ int netcp_txpipe_open(struct netcp_tx_pipe *tx_pipe)
>  
>  	tx_pipe->dma_channel = knav_dma_open_channel(dev,
>  				tx_pipe->dma_chan_name, &config);
> -	if (IS_ERR_OR_NULL(tx_pipe->dma_channel)) {
> +	if (!tx_pipe->dma_channel) {
>  		dev_err(dev, "failed opening tx chan(%s)\n",
>  			tx_pipe->dma_chan_name);
>  		ret = -EINVAL;
> @@ -1359,7 +1359,7 @@ int netcp_txpipe_open(struct netcp_tx_pipe *tx_pipe)
>  	return 0;
>  
>  err:
> -	if (!IS_ERR_OR_NULL(tx_pipe->dma_channel))
> +	if (tx_pipe->dma_channel)
>  		knav_dma_close_channel(tx_pipe->dma_channel);
>  	tx_pipe->dma_channel = NULL;
>  	return ret;
> @@ -1678,7 +1678,7 @@ static int netcp_setup_navigator_resources(struct net_device *ndev)
>  
>  	netcp->rx_channel = knav_dma_open_channel(netcp->netcp_device->device,
>  					netcp->dma_chan_name, &config);
> -	if (IS_ERR_OR_NULL(netcp->rx_channel)) {
> +	if (!netcp->rx_channel) {
>  		dev_err(netcp->ndev_dev, "failed opening rx chan(%s\n",
>  			netcp->dma_chan_name);
>  		ret = -EINVAL;



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)