linux-kernel - [PATCH v2] loop: fix backing file reference leak on validation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250930003559.708798-1-me@linux.beauty>
Date: Tue, 30 Sep 2025 08:35:59 +0800
From: Li Chen <me@...ux.beauty>
To: Jens Axboe <axboe@...nel.dk>,
	Lizhi Xu <lizhi.xu@...driver.com>,
	linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org,
	"Markus Elfring" <Markus.Elfring@....de>,
	"Yang Erkun" <yangerkun@...wei.com>,
	"Ming Lei" <ming.lei@...hat.com>,
	"Yu Kuai" <yukuai1@...weicloud.com>
Subject: [PATCH v2] loop: fix backing file reference leak on validation error

loop_change_fd() and loop_configure() call loop_check_backing_file()
to validate the new backing file. If validation fails, the reference
acquired by fget() was not dropped, leaking a file reference.

Fix this by calling fput(file) before returning the error.

Cc: stable@...r.kernel.org
Cc: "Markus Elfring"<Markus.Elfring@....de>
CC: "Yang Erkun" <yangerkun@...wei.com>
Cc: "Ming Lei"<ming.lei@...hat.com>
Cc: "Yu Kuai"<yukuai1@...weicloud.com>
Fixes: f5c84eff634b ("loop: Add sanity check for read/write_iter")
Signed-off-by: Li Chen <chenl311@...natelecom.cn>
Reviewed-by: Ming Lei <ming.lei@...hat.com>
Reviewed-by: Yang Erkun <yangerkun@...wei.com>
---
changelog:
v2: add review by, Fixes and cc stable tags.

 drivers/block/loop.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 053a086d547e..94ec7f747f36 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -551,8 +551,10 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev,
 		return -EBADF;
 
 	error = loop_check_backing_file(file);
-	if (error)
+	if (error) {
+		fput(file);
 		return error;
+	}
 
 	/* suppress uevents while reconfiguring the device */
 	dev_set_uevent_suppress(disk_to_dev(lo->lo_disk), 1);
@@ -993,8 +995,10 @@ static int loop_configure(struct loop_device *lo, blk_mode_t mode,
 		return -EBADF;
 
 	error = loop_check_backing_file(file);
-	if (error)
+	if (error) {
+		fput(file);
 		return error;
+	}
 
 	is_loop = is_loop_device(file);
 
-- 
2.51.0