linux-kernel - Re: [PATCH] PCI: sg2042: Fix a reference count issue in sg2042_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MAUPR01MB1107269A4F21DE5CC8C575077FE1AA@MAUPR01MB11072.INDPRD01.PROD.OUTLOOK.COM>
Date: Tue, 30 Sep 2025 08:43:12 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: sg2042: Fix a reference count issue in
 sg2042_pcie_remove()


On 9/30/2025 2:13 AM, Christophe JAILLET wrote:
> devm_pm_runtime_enable() is used in the probe, so pm_runtime_disable()
> should not be called explicitly in the remove function.
>
> Fixes: 1c72774df028 ("PCI: sg2042: Add Sophgo SG2042 PCIe driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

LGTM.

Acked-by: Chen Wang <unicorn_wang@...look.com>

Tested-by: Chen Wang <unicorn_wang@...look.com> # on Pioneerbox.

Thanks,

Chen

> ---
> Compile tested only
> ---
>   drivers/pci/controller/cadence/pcie-sg2042.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/controller/cadence/pcie-sg2042.c b/drivers/pci/controller/cadence/pcie-sg2042.c
> index a077b28d4894..0c50c74d03ee 100644
> --- a/drivers/pci/controller/cadence/pcie-sg2042.c
> +++ b/drivers/pci/controller/cadence/pcie-sg2042.c
> @@ -74,15 +74,12 @@ static int sg2042_pcie_probe(struct platform_device *pdev)
>   static void sg2042_pcie_remove(struct platform_device *pdev)
>   {
>   	struct cdns_pcie *pcie = platform_get_drvdata(pdev);
> -	struct device *dev = &pdev->dev;
>   	struct cdns_pcie_rc *rc;
>   
>   	rc = container_of(pcie, struct cdns_pcie_rc, pcie);
>   	cdns_pcie_host_disable(rc);
>   
>   	cdns_pcie_disable_phy(pcie);
> -
> -	pm_runtime_disable(dev);
>   }
>   
>   static int sg2042_pcie_suspend_noirq(struct device *dev)