linux-kernel - [PATCH][SMB3 CLIENT] fix bug with newly created files in cached dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAH2r5ms6vsZ7VrL2DSLXPcWOS-wcp_h5rx6qBMfb9HFcS=7eYQ@mail.gmail.com>
Date: Mon, 29 Sep 2025 23:32:17 -0500
From: Steve French <smfrench@...il.com>
To: LKML <linux-kernel@...r.kernel.org>, Bharath S M <bharathsm@...rosoft.com>
Subject: [PATCH][SMB3 CLIENT] fix bug with newly created files in cached dir

Any updates/feedback/reviews on this fix from Bharath for generic/637?

commit b10a51be25c2df37579ac5d39a4e9be47773b42c (HEAD -> for-next,
origin/for-next)
Author: Bharath SM <bharathsm@...rosoft.com>
Date:   Fri Sep 26 10:13:50 2025 -0500

    smb client: fix bug with newly created file in cached dir

    Test generic/637 spotted a problem with create of a new file in a
    cached directory (by the same client) could cause cases where the
    new file does not show up properly in ls on that client until the
    lease times out.

    Fixes: 037e1bae588e ("smb: client: use ParentLeaseKey in cifs_do_create")
    Cc: stable@...r.kernel.org
    Signed-off-by: Bharath SM <bharathsm@...rosoft.com>
    Signed-off-by: Steve French <stfrench@...rosoft.com>

diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
index bc145436eba4..a233a5fe377b 100644
--- a/fs/smb/client/dir.c
+++ b/fs/smb/client/dir.c
@@ -329,6 +329,7 @@ static int cifs_do_create(struct inode *inode,
struct dentry *direntry, unsigned
                                               parent_cfid->fid.lease_key,
                                               SMB2_LEASE_KEY_SIZE);
                                        parent_cfid->dirents.is_valid = false;
+                                       parent_cfid->dirents.is_failed = true;
                                }
                                break;
                        }


-- 
Thanks,

Steve

View attachment "0016-smb-client-fix-bug-with-newly-created-file-in-cached.patch" of type "text/x-patch" (1172 bytes)