linux-kernel - Re: [PATCH 08/29] media: mfc: Add Exynos‑MFC driver probe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPecLREbEDM4yfM=WD-EFfuBqPDXNZceATLeWQRj0X_w7w@mail.gmail.com>
Date: Tue, 30 Sep 2025 14:54:54 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Himanshu Dewangan <h.dewangan@...sung.com>
Cc: mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, sumit.semwal@...aro.org, christian.koenig@....com, 
	alim.akhtar@...sung.com, manjun@...sung.com, nagaraju.s@...sung.com, 
	ih0206.lee@...sung.com, jehyung.lee@...sung.com, 
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 08/29] media: mfc: Add Exynos‑MFC driver probe support

On Tue, 30 Sept 2025 at 12:56, Himanshu Dewangan <h.dewangan@...sung.com> wrote:
>
> From: Nagaraju Siddineni <nagaraju.s@...sung.com>
>
> Introduce a new Kconfig entry VIDEO_EXYNOS_MFC for the Samsung
> Exynos MFC driver that supports firmware version 13 and later.
> Extend the top‑level Samsung platform Kconfig to disable the legacy
> S5P‑MFC driver when its firmware version is > v12 and to select the
> new Exynos‑MFC driver only when VIDEO_SAMSUNG_S5P_MFC is not enabled.
>
> Add exynos-mfc Kconfig and Makefile for probe functionality and creation
> of decoder and encoder device files by registering the driver object
> exynos_mfc.o and other relevant source files.
>
> Provide header files mfc_core_ops.h and mfc_rm.h containing core
>   operation prototypes, resource‑manager helpers,
>   and core‑selection utilities.
>
> Add a configurable option MFC_USE_COREDUMP to enable core‑dump
> support for debugging MFC errors.
>
> These changes bring support for newer Exynos‑based MFC hardware,
> cleanly separate it from the legacy S5P‑MFC driver, and lay the
> groundwork for future feature development and debugging.
>


No, NAK. Existing driver is well tested and already used on newest
Exynos SoC, so all this new driver is exactly how you should not work
in upstream. You need to integrate into existing driver.

Samsung received this review multiple times already.
Best regards,
Krzysztof