linux-kernel - Re: [PATCH 02/29] arm64: dts: mfc: Add MFC device tree for Auto V920 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPc+ass6ftbxrodVzXVPFW+8rUYW=VyxsmGTU1wR_jBiAg@mail.gmail.com>
Date: Tue, 30 Sep 2025 15:40:41 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Himanshu Dewangan <h.dewangan@...sung.com>
Cc: mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, sumit.semwal@...aro.org, christian.koenig@....com, 
	alim.akhtar@...sung.com, manjun@...sung.com, nagaraju.s@...sung.com, 
	ih0206.lee@...sung.com, jehyung.lee@...sung.com, 
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 02/29] arm64: dts: mfc: Add MFC device tree for Auto V920 SoC

On Tue, 30 Sept 2025 at 12:55, Himanshu Dewangan <h.dewangan@...sung.com> wrote:
>
> From: Nagaraju Siddineni <nagaraju.s@...sung.com>
>
> Introduce the device‑tree entries for the Samsung Exynos AUTO V920
> multimedia‑function controller (MFC). The patch defines:
> - Reserved memory regions for firmware and CMA buffers.
> - Core0 and Core1 memory mappings.
> - The main MFC node with basic properties (compatible, reg, interrupts,
>   clocks, DMA window, firmware name, debug mode, etc.).
> - Per‑core sub‑nodes (MFC‑0 and MFC‑1) with their own sysmmu,
>   firmware region, and configuration parameters.
> - Resource table listing supported codecs and their capabilities.
>
> Adds full support for the V920 MFC hardware to the mainline kernel
> device‑tree, enabling proper memory allocation, interrupt handling and
> codec operation on this platform.
>
> Signed-off-by: Nagaraju Siddineni <nagaraju.s@...sung.com>
> Signed-off-by: Himanshu Dewangan <h.dewangan@...sung.com>
> ---
>  .../dts/exynos/exynosautov920-evt2-mfc.dtsi   | 187 ++++++++++++++++++

No, there are no such files. Don't push your downstream here.

>  .../arm64/boot/dts/exynos/exynosautov920.dtsi |   1 +
>  2 files changed, 188 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-evt2-mfc.dtsi
>

This doesn't belong to media patchset, don't combine them.

Anyway, you completely disregarded DTS coding style and how we were
Samsung DTS. Please don't send us downstream code.

I won't be reviewing this, you need to start from scratch looming at
other recent code.

Remember also about Samsung maintainer profile, although with such
completely broken and non working bindings it's pointless now - this
code couldn't even be reliably tested with them.


Best regards,
Krzysztof