linux-kernel - Re: [PATCH v2] serial: 8250_pcilib: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6fe95e5-0dd3-4ce0-b741-06cacf283e4c@kernel.org>
Date: Tue, 30 Sep 2025 09:34:30 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Florian Eckert <fe@....tdt.de>, gregkh@...uxfoundation.org,
 kumaravel.thiagarajan@...rochip.com, andriy.shevchenko@...ux.intel.com,
 pnewman@...necttech.com, angelogioacchino.delregno@...labora.com,
 peterz@...radead.org, yujiaoliang@...o.com, arnd@...nel.org,
 cang1@...e.co.uk, macro@...am.me.uk, schnelle@...ux.ibm.com,
 Eckert.Florian@...glemail.com
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] serial: 8250_pcilib: Replace deprecated PCI functions

On 30. 09. 25, 9:27, Florian Eckert wrote:
> When the '8250_exar' module is loaded into the kernel, a kernel trace
> with 'WARN_ON(legacy_iomap_table[bar])' is dumped to the console,
> because the old pci table mapping is still used in '8250_pcilib'.
> 
> The old function have been deprecated in commit e354bb84a4c1 ("PCI:
> Deprecate pcim_iomap_table(), pcim_iomap_regions_request_all()").
> 
> The remapping already takes or must take place in the driver that calls
> the function 'serial8250_pci_setup_port()'. The remapping should only be
> called once via 'pcim_iomap()'. Therefore the remapping moved to the
> caller of 'serial8250_pci_setup_port()'.
> 
> To replace the outdated/legacy iomap_table processing in '8250_pcilib' the
> function signature of 'serial8250_pci_setup_port()' has been extended with
> an already iomapped address value. So this can be used directly without
> io mapping again.
> 
> Signed-off-by: Florian Eckert <fe@....tdt.de>
> ---
> 
> v2:
> * The function 'pcim_iomap()' returns a NULL pointer in the event of an
>    error, so error handling has been adjusted.

LGTM now.

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>


-- 
js
suse labs