linux-kernel - Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAyq3SYyqi-oR8T039Zd0uaF6UieX3SdF9UF2kxOG6+yJqAEUg@mail.gmail.com>
Date: Tue, 30 Sep 2025 15:36:40 +0800
From: Cheng Ming Lin <linchengming884@...il.com>
To: Michael Walle <mwalle@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Guenter Roeck <linux@...ck-us.net>, 
	Pratyush Yadav <pratyush@...nel.org>, Cheng Ming Lin <chengminglin@...c.com.tw>, 
	miquel.raynal@...tlin.com, richard@....at, vigneshr@...com, 
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	alvinzhou@...c.com.tw, leoyu@...c.com.tw, 
	Maarten Zanders <maarten@...ders.be>
Subject: Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash
 info fields

Hi Michael,

Michael Walle <mwalle@...nel.org> 於 2025年9月24日 週三 下午8:11寫道：
>
> > The root cause of this problem lies in the failure of parsing the SFDP
> > data for the flash, rather than an issue with the patch itself. I believe
> > we should not revert this patch.
>
> I disagree. There are Macronix flashes with that ID which doesn't
> have SFDP.  And this patch is dropping support for them. See also
> [1]. Now I'm not sure it is worth reverting this commit. Nobody,
> except Guenter complained, but only *so far* (and that patch is in
> since 6.16). Any opinions?

I agree with reverting this patch. When I initially verified it, the
devices I had on hand all supported SFDP, so I did not catch this issue.
After checking again, I confirm that some older flashes without SFDP are
indeed affected.

Would it make sense to only change the `.name` field to use a comment,
while keeping the rest as is? That way we can still support flashes that
may not provide SFDP.

>
> -michael
>
> [1] https://lore.kernel.org/r/DD10GE4EOCD7.CPTN7198QFUV@kernel.org/

Thanks,
Cheng Ming Lin