linux-kernel - RE: [PATCH rtw-next v2] wifi: rtw89: Replace hardcoded strings with helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7b36065cc1549a6aa8c2f2c95bdad3f@realtek.com>
Date: Tue, 30 Sep 2025 01:19:41 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Yu-Chun Lin <eleanor15x@...il.com>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jserv@...s.ncku.edu.tw" <jserv@...s.ncku.edu.tw>,
        "visitorckw@...il.com"
	<visitorckw@...il.com>,
        Stanley Chang[昌育德]
	<stanley_chang@...ltek.com>,
        CY_Huang[黃鉦晏]
	<cy.huang@...ltek.com>
Subject: RE: [PATCH rtw-next v2] wifi: rtw89: Replace hardcoded strings with helper functions

Yu-Chun Lin <eleanor15x@...il.com> wrote:
> Replace hardcoded strings with 'str_on_off()', 'str_enable_disable()',
> and 'str_read_write()'.
> 
> The change improves readability.
> 
> Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>


> diff --git a/drivers/net/wireless/realtek/rtw89/wow.c b/drivers/net/wireless/realtek/rtw89/wow.c
> index 5faa51ad896a..6950fed96267 100644
> --- a/drivers/net/wireless/realtek/rtw89/wow.c
> +++ b/drivers/net/wireless/realtek/rtw89/wow.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
>  /* Copyright(c) 2019-2022  Realtek Corporation
>   */
> +

No need to add this blink line. I'll remove this when merging patch. 
(Sending v3 is also fine to me)

>  #include "cam.h"
>  #include "core.h"
>  #include "debug.h"
> @@ -1248,7 +1249,7 @@ static int rtw89_wow_check_fw_status(struct rtw89_dev *rtwdev, bool wow_enable)
>                                        mac->wow_ctrl.addr, mac->wow_ctrl.mask);
>         if (ret)
>                 rtw89_err(rtwdev, "failed to check wow status %s\n",
> -                         wow_enable ? "enabled" : "disabled");
> +                         str_enabled_disabled(wow_enable));
>         return ret;
>  }
> 
> --
> 2.34.1