linux-kernel - Re: [PATCH net-next] selftests/net: add tcp_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNuci8Y9ZO9pd0Ua@horms.kernel.org>
Date: Tue, 30 Sep 2025 10:02:03 +0100
From: Simon Horman <horms@...nel.org>
To: Gopi Krishna Menon <krishnagopi487@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, shuah@...nel.org, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	david.hunter.linux@...il.com, skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH net-next] selftests/net: add tcp_port_share to .gitignore

On Tue, Sep 30, 2025 at 09:59:44AM +0100, Simon Horman wrote:
> On Mon, Sep 29, 2025 at 10:01:38PM +0530, Gopi Krishna Menon wrote:
> > Add the tcp_port_share test binary to .gitignore to avoid
> > accidentally staging the build artifact.
> > 
> > Fixes: 8a8241cdaa34 ("selftests/net: Test tcp port reuse after unbinding
> > a socket")
> 
> I'm not entirely sure this qualifies for a fixes tag.
> It is user-visible. It's probably annoying.
> But I'm not sure it's a bug.

Also, FTR, fixes tag's shouldn't be line wrapped.

> > Signed-off-by: Gopi Krishna Menon <krishnagopi487@...il.com>
> > ---
> >  tools/testing/selftests/net/.gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> I notice that tools/testing/selftests/kexec/test_kexec_jump
> is in a similar state. Do you plan to send a patch to address
> that too?
> 
> ..

Please note that net-next is now closed.

So if you do respin, please wait for it to re-open once v6.18-rc1 has been
released. About two weeks from now.