| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <41c2a141-a72e-4780-ab32-f22f3a2e0179@samsung.com> Date: Tue, 30 Sep 2025 12:17:26 +0200 From: Marek Szyprowski <m.szyprowski@...sung.com> To: Damon Ding <damon.ding@...k-chips.com>, andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org Cc: Laurent.pinchart@...asonboard.com, jonas@...boo.se, jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, inki.dae@...sung.com, sw0312.kim@...sung.com, kyungmin.park@...sung.com, krzk@...nel.org, alim.akhtar@...sung.com, jingoohan1@...il.com, p.zabel@...gutronix.de, hjc@...k-chips.com, heiko@...ech.de, andy.yan@...k-chips.com, dmitry.baryshkov@....qualcomm.com, dianders@...omium.org, luca.ceresoli@...tlin.com, jani.nikula@...el.com, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org Subject: Re: [PATCH v6 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver On 30.09.2025 11:09, Damon Ding wrote: > PATCH 1 is a small format optimization for struct analogid_dp_device. > PATCH 2 is to perform mode setting in &drm_bridge_funcs.atomic_enable. > PATCH 3 is to add a new parameter to store the point of next bridge. > PATCH 4 is to make legacy bridge driver more universal. > PATCH 5-10 are preparations for apply drm_bridge_connector helper. > PATCH 11 is to ensure last bridge determines OP_EDID/OP_MODES capabilities. > PATCH 12 is to apply the drm_bridge_connector helper. > PATCH 13-15 are to move the panel/bridge parsing to the Analogix side. > PATCH 16 is to attach the next bridge on Analogix side uniformly. > PATCH 17-18 are to apply the panel_bridge helper. Works fine on my Exynos based test boards with (e)DP displays. Thanks! Feel free to update tags if needed: Tested-by: Marek Szyprowski <m.szyprowski@...sung.com> > Damon Ding (18): > drm/bridge: analogix_dp: Formalize the struct analogix_dp_device > drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to > &drm_bridge_funcs.atomic_enable > drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge > drm/bridge: Move legacy bridge driver out of imx directory for > multi-platform use > drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge > drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector > drm/exynos: exynos_dp: Apply legacy bridge to parse the > display-timings node > drm/bridge: analogix_dp: Remove redundant > &analogix_dp_plat_data.skip_connector > drm/bridge: analogix_dp: Move the color format check to > .atomic_check() for Rockchip platforms > drm/bridge: analogix_dp: Remove unused > &analogix_dp_plat_data.get_modes() > drm/display: bridge_connector: Ensure last bridge determines > EDID/modes detection capabilities > drm/bridge: analogix_dp: Apply drm_bridge_connector helper > drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() > drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() > drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() > drm/bridge: analogix_dp: Attach the next bridge in > analogix_dp_bridge_attach() > drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing > in analogix_dp_unbind() > drm/bridge: analogix_dp: Apply panel_bridge helper > > drivers/gpu/drm/bridge/Kconfig | 10 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > .../drm/bridge/analogix/analogix_dp_core.c | 395 +++++++++--------- > .../drm/bridge/analogix/analogix_dp_core.h | 5 +- > drivers/gpu/drm/bridge/imx/Kconfig | 10 - > drivers/gpu/drm/bridge/imx/Makefile | 1 - > .../gpu/drm/bridge/imx/imx-legacy-bridge.c | 91 ---- > drivers/gpu/drm/bridge/legacy-bridge.c | 99 +++++ > .../gpu/drm/display/drm_bridge_connector.c | 42 ++ > drivers/gpu/drm/exynos/Kconfig | 2 + > drivers/gpu/drm/exynos/exynos_dp.c | 117 ++---- > drivers/gpu/drm/imx/ipuv3/Kconfig | 4 +- > drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 6 +- > drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 +- > drivers/gpu/drm/rockchip/Kconfig | 1 + > .../gpu/drm/rockchip/analogix_dp-rockchip.c | 67 +-- > include/drm/bridge/analogix_dp.h | 8 +- > include/drm/bridge/imx.h | 17 - > include/drm/bridge/legacy-bridge.h | 18 + > 20 files changed, 433 insertions(+), 466 deletions(-) > delete mode 100644 drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > create mode 100644 drivers/gpu/drm/bridge/legacy-bridge.c > delete mode 100644 include/drm/bridge/imx.h > create mode 100644 include/drm/bridge/legacy-bridge.h > > --- > > Changes in v2: > - Update Exynos DP driver synchronously. > - Move the panel/bridge parsing to the Analogix side. > > Changes in v3: > - Rebase for the existing devm_drm_bridge_alloc() applying commit. > - Fix the typographical error of panel/bridge check in exynos_dp_bind(). > - Squash all commits related to skip_connector deletion in both Exynos and > Analogix code into one. > - Apply panel_bridge helper to make the codes more concise. > - Fix the handing of bridge in analogix_dp_bridge_get_modes(). > - Remove unnecessary parameter struct drm_connector* for callback > &analogix_dp_plat_data.attach(). > - In order to decouple the connector driver and the bridge driver, move > the bridge connector initilization to the Rockchip and Exynos sides. > > Changes in v4: > - Rebase for the applied &drm_bridge_funcs.detect() modification commit. > - Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe(). > - Drop the drmm_encoder_init() modification commit. > - Rename the &analogix_dp_plat_data.bridge to > &analogix_dp_plat_data.next_bridge. > > Changes in v5: > - Add legacy bridge to parse the display-timings node under the dp node > for Exynos side. > - Move color format check to &drm_connector_helper_funcs.atomic_check() > in order to get rid of &analogix_dp_plat_data.get_modes(). > - Remove unused callback &analogix_dp_plat_data.get_modes(). > - Distinguish the &drm_bridge->ops of Analogix bridge based on whether > the downstream device is a panel, a bridge or neither. > - Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP, and remove it for > ROCKCHIP_ANALOGIX_DP. > - Apply rockchip_dp_attach() to support the next bridge attachment for > the Rockchip side. > - Move next_bridge attachment from Analogix side to Rockchip/Exynos sides. > > Changes in v6: > - Move legacy bridge driver out of imx directory for multi-platform use. > - Apply DRM legacy bridge to parse display timings intead of implementing > the same codes only for Exynos DP. > - Ensure last bridge determines EDID/modes detection capabilities in DRM > bridge_connector driver. > - Remove unnecessary drm_bridge_get_modes() in > analogix_dp_bridge_get_modes(). > - Simplify analogix_dp_bridge_edid_read(). > - If the next is a bridge, set DRM_BRIDGE_OP_DETECT and return > connector_status_connected in analogix_dp_bridge_detect(). > - Set flag DRM_BRIDGE_ATTACH_NO_CONNECTOR for bridge attachment while > binding. Meanwhile, make DRM_BRIDGE_ATTACH_NO_CONNECTOR unsuppported > in analogix_dp_bridge_attach(). > - Move the next bridge attachment to the Analogix side rather than > scattered on Rockchip and Exynos sides. > - Remove the unnecessary analogix_dp_bridge_get_modes(). > - Squash [PATCH v5 15/17] into [PATCH v5 17/17]. > - Fix the &drm_bridge->ops to DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT. > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
Powered by blists - more mailing lists