linux-kernel - Re: [PATCH] clk: fix slab-use-after-free when clk_core_populate_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNuvghjOrY7nSviZ@redhat.com>
Date: Tue, 30 Sep 2025 06:22:58 -0400
From: Brian Masney <bmasney@...hat.com>
To: "Zhou, Yun" <yun.zhou@...driver.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, dianders@...omium.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: fix slab-use-after-free when
 clk_core_populate_parent_map failed

Hi Yun,

On Tue, Sep 30, 2025 at 12:59:14PM +0800, Zhou, Yun wrote:
> Hi Brian,
> 
> Thanks for your review.
> 
> This defect is caused by multiple reasons, but as you said, the fixes tag is
> not accurate enough.
> 
> I think it should be:
> 
> Fixes: fc0c209c1 ("clk: Allow parents to be specified without string names")
> 
> Do you think so?

Yes, that's what I would make it. With that fixed in a v2, you can add:

Reviewed-by: Brian Masney <bmasney@...hat.com>

Also, just a heads up to not top post, and to reply inline next time.

https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying

Brian