linux-kernel - Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aab3bf2f-b778-4754-a1ac-5e5e32e54743@tuxon.dev>
Date: Tue, 30 Sep 2025 13:24:21 +0300
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linus.walleij@...aro.org, biju.das.jz@...renesas.com,
 linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume

Hi, Geert,

On 9/30/25 13:20, Geert Uytterhoeven wrote:
> Hi Claudiu,
> 
> On Tue, 30 Sept 2025 at 07:33, Claudiu Beznea <claudiu.beznea@...on.dev> wrote:
>> On 9/29/25 15:10, Claudiu Beznea wrote:
>>>> This conflicts with commit d57183d06851bae4 ("pinctrl: renesas: rzg2l:
>>>> Drop unnecessary pin configurations"), which I have already queued
>>>> in renesas-drivers/renesas-pinctrl-for-v6.19.  Hence I am replacing
>>>> the above hunk by:
>>>>
>>>>             /* Switching to GPIO is not required if reset value is
>>>> same as func */
>>>>             reg = readb(pctrl->base + PMC(off));
>>>>     -       spin_lock_irqsave(&pctrl->lock, flags);
>>>>     +       raw_spin_lock_irqsave(&pctrl->lock, flags);
>>>>             pfc = readl(pctrl->base + PFC(off));
>>>>             if ((reg & BIT(pin)) && (((pfc >> (pin * 4)) & PFC_MASK) == func)) {
>>>>     -               spin_unlock_irqrestore(&pctrl->lock, flags);
>>>>     +               raw_spin_unlock_irqrestore(&pctrl->lock, flags);
>>>>                     return;
>>>>             }
>>>>
>>>> while applying.
>>> This is right. Thank you! I'm going to give it also a try (on actual HW) a
>>> bit later. I'll let you know.
>>
>> Sorry for the delay, all looks good to me (checked on RZ/G3S).
> 
> Given this is a fix which will be backported, I will reshuffle both
> commits, so your fix is first, and the above no longer applies (here).

That's OK for me. Thank you for handling it.

Claudiu

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>