linux-kernel - Re: [PATCH 1/1] mm: prevent poison consumption when splitting THP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABzRoya5wuXoMWuGb_+F0oBc0mCDVrjbXTZsoMwcfRT99Y5z7g@mail.gmail.com>
Date: Tue, 30 Sep 2025 09:48:34 +0800
From: Lance Yang <lance.yang@...ux.dev>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>, David Hildenbrand <david@...hat.com>
Cc: "Luck, Tony" <tony.luck@...el.com>, Jiaqi Yan <jiaqiyan@...gle.com>, 
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, 
	"lorenzo.stoakes@...cle.com" <lorenzo.stoakes@...cle.com>, "linmiaohe@...wei.com" <linmiaohe@...wei.com>, 
	"ziy@...dia.com" <ziy@...dia.com>, 
	"baolin.wang@...ux.alibaba.com" <baolin.wang@...ux.alibaba.com>, 
	"Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>, "npache@...hat.com" <npache@...hat.com>, 
	"ryan.roberts@....com" <ryan.roberts@....com>, "dev.jain@....com" <dev.jain@....com>, 
	"baohua@...nel.org" <baohua@...nel.org>, "nao.horiguchi@...il.com" <nao.horiguchi@...il.com>, 
	"Chen, Farrah" <farrah.chen@...el.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	Andrew Zaborowski <andrew.zaborowski@...el.com>
Subject: Re: [PATCH 1/1] mm: prevent poison consumption when splitting THP

On Tue, Sep 30, 2025 at 3:07 AM David Hildenbrand <david@...hat.com> wrote:
>
> On 29.09.25 18:30, Zhuo, Qiuxu wrote:
> > Hi Tony,
> >
> >> From: Luck, Tony <tony.luck@...el.com>
> >> [...]
> >> Subject: RE: [PATCH 1/1] mm: prevent poison consumption when splitting THP
> >>
> >>> Miaohe mentioned in another e-mail that there was an HWPoisoned flag
> >> for the raw error 4K page.
> >>> We could use that flag just to skip that raw error page and still use
> >>> the zeropage for other healthy sub-pages. I'll try that.
> >>
> >> That HWPoisoned flag is only set for raw pages where an error has been
> >> detected. Maybe Linux could implement an
> >> "is_this_page_all_zero_mc_safe()"[1] that would catch undetected poison
> >
> > This sounds like a great suggestion to me.
> > Let's see what others think about this and the name (though the name already LGTM 😊).
>
> The function name is just ... special. Not the good type of special IMHO. :)
>
> Note that we'll be moving to pages_identical() in [1]. Maybe we would
> want a pages_identical_mc() or sth. like that as a follow up later.
>
>
> So in any case, make that a follow-up work on top of a simple fix.

Yeah. IIRC, as David suggested earlier, we can just check if a page is
poisoned using PageHWPoison().

Perhaps we should move this check into pages_identical()? This would make
it a central place to determine if pages are safe to access and merge ;)

BTW, could you please keep me in the loop for the next version?

Thanks,
Lance

>
> [1] https://lore.kernel.org/all/20250922021458.68123-1-lance.yang@linux.dev/
>
> --
> Cheers
>
> David / dhildenb
>
>