linux-kernel - Re: [PATCH v3] ext4: detect invalid INLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250930112620.315028-1-kartikey406@gmail.com>
Date: Tue, 30 Sep 2025 16:56:20 +0530
From: Deepanshu Kartikey <kartikey406@...il.com>
To: tytso@....edu,
	adilger.kernel@...ger.ca,
	yi.zhang@...weicloud.com
Cc: linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ext4: detect invalid INLINE_DATA + EXTENTS flag combination

Zhang Yi,

Thank you for the clarification about checking flags directly versus 
ext4_has_inline_data() return value. You're absolutely right - since 
I'm checking the flags themselves which don't change after being set 
from disk, the check can and should be placed right after 
ext4_set_inode_flags().

I've sent v4 with the check moved to the earlier location as you 
suggested. This placement is indeed more logical - detecting invalid 
flag combinations immediately after reading them from disk.

The patch has been tested by syzbot and confirms it fixes the issue.

Thank you for your patience and thorough review that helped identify 
the proper fix for this issue.

Best regards,
Deepanshu